Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Plugin: Prefer next script component when using the inline script for Google Analytics. #25147

Merged
merged 8 commits into from Aug 16, 2021

Conversation

rgabs
Copy link
Contributor

@rgabs rgabs commented May 14, 2021

Add a lint rule for using next script component when using inline script for Google Analytics.

@rgabs rgabs force-pushed the eslint/next-script-for-ga branch from a613731 to 5462fd3 Compare May 20, 2021 18:06
@rgabs rgabs force-pushed the eslint/next-script-for-ga branch 2 times, most recently from 404c23d to 3de71a9 Compare May 20, 2021 18:11
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@rgabs rgabs force-pushed the eslint/next-script-for-ga branch from e12bf22 to 2ed0651 Compare May 21, 2021 19:29
@ijjk

This comment has been minimized.

@rgabs rgabs force-pushed the eslint/next-script-for-ga branch from 2837d90 to 47a7de7 Compare June 2, 2021 16:47
@ijjk

This comment has been minimized.

@rgabs rgabs force-pushed the eslint/next-script-for-ga branch 2 times, most recently from 32db3c6 to 5315199 Compare June 14, 2021 17:44
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@rgabs rgabs force-pushed the eslint/next-script-for-ga branch 4 times, most recently from 5a18271 to 70143f7 Compare August 16, 2021 13:30
@ijjk

This comment has been minimized.

errors/next-script-for-ga.md Outdated Show resolved Hide resolved
errors/next-script-for-ga.md Outdated Show resolved Hide resolved
errors/next-script-for-ga.md Outdated Show resolved Hide resolved
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@ijjk

This comment has been minimized.

Co-authored-by: JJ Kasper <jj@jjsweb.site>
errors/next-script-for-ga.md Outdated Show resolved Hide resolved
@ijjk

This comment has been minimized.

errors/next-script-for-ga.md Outdated Show resolved Hide resolved
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 16, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
buildDuration 11.7s 11.6s -152ms
buildDurationCached 2.9s 2.9s -17ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
/ failed reqs 0 0
/ total time (seconds) 2.265 2.308 ⚠️ +0.04
/ avg req/sec 1103.7 1083.38 ⚠️ -20.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.263 1.27 ⚠️ +0.01
/error-in-render avg req/sec 1979.91 1967.76 ⚠️ -12.15
Client Bundles (main, webpack, commons)
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.64 kB 2.64 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
index.html gzip 540 B 540 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
buildDuration 9.5s 9.5s ⚠️ +25ms
buildDurationCached 4s 3.9s -78ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
/ failed reqs 0 0
/ total time (seconds) 2.337 2.345 ⚠️ +0.01
/ avg req/sec 1069.56 1066 ⚠️ -3.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.322 1.283 -0.04
/error-in-render avg req/sec 1891.32 1948.2 +56.88
Client Bundles (main, webpack, commons)
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.83 kB 2.83 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.8 kB 17.8 kB
Client Build Manifests
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary rgabs/next.js eslint/next-script-for-ga Change
index.html gzip 584 B 584 B
link.html gzip 596 B 596 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: dc41892

@ijjk ijjk merged commit da4d652 into vercel:canary Aug 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants