ESLint Config: Adds `alt` text rule for Image #25462

housseindjirdeh · 2021-05-25T17:22:32Z

Adds eslint-plugin-jsx-a11y to Next.js' ESLint config
Enables jsx-a11y/alt-text rule for Image component by default (as a warning)

ijjk · 2021-05-28T13:06:54Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
buildDuration	16.6s	16.7s	⚠️ +153ms
buildDurationCached	4.6s	4.5s	-50ms
nodeModulesSize	46.7 MB	46.7 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.919	2.95	⚠️ +0.03
/ avg req/sec	856.6	847.38	⚠️ -9.22
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.722	1.783	⚠️ +0.06
/error-in-render avg req/sec	1451.81	1402.34	⚠️ -49.47

Client Bundles (main, webpack, commons)

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.4 kB	19.4 kB	✓
webpack-HASH.js gzip	994 B	994 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.52 kB	8.52 kB	✓

Client Build Manifests

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
_buildManifest.js gzip	392 B	392 B	✓
Overall change	392 B	392 B	✓

Rendered Page Sizes

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
index.html gzip	562 B	562 B	✓
link.html gzip	569 B	569 B	✓
withRouter.html gzip	558 B	558 B	✓
Overall change	1.69 kB	1.69 kB	✓

Serverless Mode

General

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
buildDuration	19.5s	19.2s	-307ms
buildDurationCached	5.8s	5.7s	-42ms
nodeModulesSize	46.7 MB	46.7 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.4 kB	19.4 kB	✓
webpack-HASH.js gzip	994 B	994 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.52 kB	8.52 kB	✓

Client Build Manifests

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
_buildManifest.js gzip	392 B	392 B	✓
Overall change	392 B	392 B	✓

Serverless bundles

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	2.42 kB	2.42 kB	✓
500.html	2.41 kB	2.41 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.61 kB	1.61 kB	✓
css.html	1.79 kB	1.79 kB	✓
hooks.html	1.67 kB	1.67 kB	✓
index.js	17.2 kB	17.2 kB	✓
link.js	17.4 kB	17.4 kB	✓
routerDirect.js	17.4 kB	17.4 kB	✓
withRouter.js	17.4 kB	17.4 kB	✓
Overall change	107 kB	107 kB	✓

Webpack 4 Mode (Decrease detected ✓)

General

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
buildDuration	15s	15s	⚠️ +13ms
buildDurationCached	6.3s	6.2s	-109ms
nodeModulesSize	46.7 MB	46.7 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.079	3.024	-0.06
/ avg req/sec	811.98	826.64	+14.66
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.815	1.851	⚠️ +0.04
/error-in-render avg req/sec	1377.15	1350.83	⚠️ -26.32

Client Bundles (main, webpack, commons)

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
677f882d2ed8..HASH.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.26 kB	7.26 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.63 kB	1.63 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.37 kB	9.37 kB	✓

Client Build Manifests

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	housseindjirdeh/next.js img-alt-text-eslint-rule	Change
index.html gzip	612 B	612 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: a07e9e9

ijjk · 2021-05-28T13:07:11Z

Failing test suites

Commit: a07e9e9

test/integration/build-output/test/index.test.js

Build Output > Basic Application Output (with experimental.gzipSize: false) > should not deviate from snapshot

Expand output

● Build Output › Basic Application Output (with experimental.gzipSize: false) › should not deviate from snapshot

expect(received).toBeCloseTo(expected, precision)

Expected: 60.4
Received: 60.5

Expected precision:    1
Expected difference: < 0.05
Received difference:   0.10000000000000142

  150 |           )
  151 |
> 152 |           expect(parseFloat(mainSize)).toBeCloseTo(gz ? 19.4 : 60.4, 1)
      |                                        ^
  153 |           expect(mainSize.endsWith('kB')).toBe(true)
  154 |
  155 |           expect(parseFloat(frameworkSize)).toBeCloseTo(gz ? 42.0 : 130, 1)

  at Object.<anonymous> (integration/build-output/test/index.test.js:152:40)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Tim Neutkens <tim@timneutkens.nl>

adds jsx a11y plugin and enables alt text rule for images to warnings

cde2354

housseindjirdeh requested review from divmain, ijjk, lfades, shuding and timneutkens as code owners May 25, 2021 17:22

This comment has been minimized.

Sign in to view

timneutkens approved these changes May 28, 2021

View reviewed changes

kodiakhq bot added 4 commits May 28, 2021 12:46

Merge branch 'canary' into img-alt-text-eslint-rule

d63a202

Merge branch 'canary' into img-alt-text-eslint-rule

2b06f0c

Merge branch 'canary' into img-alt-text-eslint-rule

78af239

Merge branch 'canary' into img-alt-text-eslint-rule

a07e9e9

Merge branch 'canary' into img-alt-text-eslint-rule

cc50f2d

timneutkens approved these changes Jun 1, 2021

View reviewed changes

timneutkens merged commit 89dd5c1 into vercel:canary Jun 1, 2021

JeffersonBledsoe mentioned this pull request Jun 4, 2021

ESLint Config: Adds some more basic a11y rules #25770

Merged

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021

ESLint Config: Adds alt text rule for Image (vercel#25462)

bc14377

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Tim Neutkens <tim@timneutkens.nl>

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ESLint Config: Adds `alt` text rule for Image #25462

ESLint Config: Adds `alt` text rule for Image #25462

housseindjirdeh commented May 25, 2021

This comment has been minimized.

ijjk commented May 28, 2021

ijjk commented May 28, 2021

ESLint Config: Adds alt text rule for Image #25462

ESLint Config: Adds alt text rule for Image #25462

Conversation

housseindjirdeh commented May 25, 2021

This comment has been minimized.

ijjk commented May 28, 2021

Stats from current PR

ijjk commented May 28, 2021

Failing test suites

ESLint Config: Adds `alt` text rule for Image #25462

ESLint Config: Adds `alt` text rule for Image #25462