Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume a recent react@experimental if reactRoot is set #25496

Merged
merged 1 commit into from May 28, 2021
Merged

Assume a recent react@experimental if reactRoot is set #25496

merged 1 commit into from May 28, 2021

Conversation

devknoll
Copy link
Contributor

Since createRoot stabilized in the experimental channel, we should assume you're using it. We should also assume that if you're using it, the React version is greater than 17.0.0-rc.1 for the purposes of using the new JSX runtime.

@devknoll devknoll changed the title Assume you're using the latest experimental if reactRoot is set Assume a recent react@experimental if reactRoot is set May 26, 2021
@ijjk
Copy link
Member

ijjk commented May 26, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
buildDuration 14.5s 14.6s ⚠️ +133ms
buildDurationCached 4s 3.9s -68ms
nodeModulesSize 46.7 MB 46.7 MB -284 B
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.623 2.542 -0.08
/ avg req/sec 953.15 983.43 +30.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.413 1.409 0
/error-in-render avg req/sec 1769.83 1773.71 +3.88
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
index.html gzip 560 B 560 B ✓
link.html gzip 568 B 568 B ✓
withRouter.html gzip 556 B 556 B ✓
Overall change 1.68 kB 1.68 kB ✓

Diffs

Diff for main-HASH.js 
@@ -1421,7 +1421,6 @@
         );
 
         if (false) {
-          var createRootName;
         } else {
           // The check for `.hydrate` is there to support React alternatives like preact
           if (shouldHydrate) {
Diff for index.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-748cc50278e954098517.js"
+      href="/_next/static/chunks/main-83ab802b7dc3de1b8b45.js"
       as="script"
     />
     <link
@@ -56,7 +56,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/main-748cc50278e954098517.js"
+      src="/_next/static/chunks/main-83ab802b7dc3de1b8b45.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-748cc50278e954098517.js"
+      href="/_next/static/chunks/main-83ab802b7dc3de1b8b45.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/main-748cc50278e954098517.js"
+      src="/_next/static/chunks/main-83ab802b7dc3de1b8b45.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-748cc50278e954098517.js"
+      href="/_next/static/chunks/main-83ab802b7dc3de1b8b45.js"
       as="script"
     />
     <link
@@ -56,7 +56,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/main-748cc50278e954098517.js"
+      src="/_next/static/chunks/main-83ab802b7dc3de1b8b45.js"
       async=""
     ></script>
     <script
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
buildDuration 16.7s 16.9s ⚠️ +198ms
buildDurationCached 5.3s 5s -259ms
nodeModulesSize 46.7 MB 46.7 MB -284 B
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ⚠️ +4 B
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ⚠️ +4 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
buildDuration 13.1s 13.1s ⚠️ +58ms
buildDurationCached 5.5s 5.4s -69ms
nodeModulesSize 46.7 MB 46.7 MB -284 B
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.652 2.647 -0.01
/ avg req/sec 942.51 944.4 +1.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.429 1.406 -0.02
/error-in-render avg req/sec 1749.66 1777.59 +27.93
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.25 kB 7.25 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary azukaru/next.js x-assume-latest-experimental Change
index.html gzip 613 B 611 B -2 B
link.html gzip 620 B 619 B -1 B
withRouter.html gzip 606 B 605 B -1 B
Overall change 1.84 kB 1.83 kB -4 B

Diffs

Diff for main-HASH.js 
@@ -986,7 +986,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         );
 
         if (false) {
-          var createRootName;
         } else {
           // The check for `.hydrate` is there to support React alternatives like preact
           if (shouldHydrate) {
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-92b76053297198c420e1.js"
+      href="/_next/static/chunks/main-d6f5a8018cefe68fd4ae.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/main-92b76053297198c420e1.js"
+      src="/_next/static/chunks/main-d6f5a8018cefe68fd4ae.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-92b76053297198c420e1.js"
+      href="/_next/static/chunks/main-d6f5a8018cefe68fd4ae.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/main-92b76053297198c420e1.js"
+      src="/_next/static/chunks/main-d6f5a8018cefe68fd4ae.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-92b76053297198c420e1.js"
+      href="/_next/static/chunks/main-d6f5a8018cefe68fd4ae.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/main-92b76053297198c420e1.js"
+      src="/_next/static/chunks/main-d6f5a8018cefe68fd4ae.js"
       async=""
     ></script>
     <script
Commit: 12c5693

@timneutkens timneutkens merged commit bd58934 into vercel:canary May 28, 2021
@timneutkens timneutkens deleted the x-assume-latest-experimental branch May 28, 2021 12:52
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@devknoll
Assume a recent react@experimental if reactRoot is set (vercel#25496
8f6f62b 
)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devknoll @ijjk @timneutkens