Example: Treat "mockServiceWorker" as a generated artifact in "with-msw" #25515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
kettanaito
changed the title
leerob
approved these changes
May 27, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 16, 2021
…sw" (vercel#25515) ## Changes - Removes `mockServiceWorker.js` file and ignores it from Git. New versions of `msw` generate the worker script automatically at the location specified in `packageJson.msw.workerDirectory`. This keeps the worker script up-to-date with the currently installed version of `msw`. - Updates `msw` package to the latest version for new features and stability improvements. ## Documentation / Examples - [ ] Make sure the linting passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
mockServiceWorker.jsfile and ignores it from Git. New versions ofmswgenerate the worker script automatically at the location specified inpackageJson.msw.workerDirectory. This keeps the worker script up-to-date with the currently installed version ofmsw.mswpackage to the latest version for new features and stability improvements.Documentation / Examples