Improve documentation of CDN asset paths #25531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasboyt
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 16, 2021
I've been working on adding CDN support to my Next.js app and was very surprised to find that the `assetPrefix` did not turn `/_next/static/chunks/sha.js` into `$assetPrefix/chunks/sha.js`, but instead `$assetPrefix/_next/static/chunks/sha.js`. Hopefully this change to the documentation will make this behavior much more clear to future users. I've also incorporated a warning against uploading the entire `.next` folder to a CDN, as I saw @timneutkens note in a discussion here: vercel#11622 (reply in thread) ## Documentation / Examples - [ ] Make sure the linting passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on adding CDN support to my Next.js app and was very surprised to find that the
assetPrefixdid not turn/_next/static/chunks/sha.jsinto$assetPrefix/chunks/sha.js, but instead$assetPrefix/_next/static/chunks/sha.js. Hopefully this change to the documentation will make this behavior much more clear to future users.I've also incorporated a warning against uploading the entire
.nextfolder to a CDN, as I saw @timneutkens note in a discussion here: #11622 (reply in thread)Documentation / Examples