-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tsconfig of example to be consistent with default output of next.js #25581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been removed from the default TypeScript setup as well? It seems so. We should probably update these ones too: https://github.com/vercel/next.js/search?q=alwaysStrict
Thanks for reviewing! Below is a sample of next.js 10.2.3 created
|
I am not sure what is the best tsconfig for examples, but all of tsconfig of examples you suggested has the redundant rule. |
Let's be consistent with the default output of new Next.js projects 😄 |
Thank you for replying! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Sorry to bother you, I forgot to apply format |
…xt.js (vercel#25581) remove `alwaysStrict: true` rule from tsconfig.json in with-typescript example, because the rule is included in `strict: true` has been already written in tsconfig.json and other included rules such as `noImplicitAny: true` have not been written. [tsconfig documentation link](https://www.typescriptlang.org/tsconfig#alwaysStrict) ## Documentation / Examples - [x] Make sure the linting passes
remove
alwaysStrict: true
rule from tsconfig.json in with-typescript example, because the rule is included instrict: true
has been already written in tsconfig.json and other included rules such asnoImplicitAny: true
have not been written.tsconfig documentation link
Documentation / Examples