Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show webpack version message in production server #25654

Merged
merged 2 commits into from Jun 2, 2021
Merged

Don't show webpack version message in production server #25654

merged 2 commits into from Jun 2, 2021

Conversation

timneutkens
Copy link
Member

Fixes #23498 (comment)

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented May 31, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
buildDuration 11.6s 11.7s ⚠️ +100ms
buildDurationCached 3.3s 3.2s -48ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +519 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.08 2.015 -0.06
/ avg req/sec 1201.81 1240.6 +38.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.129 1.088 -0.04
/error-in-render avg req/sec 2213.48 2297.76 +84.28
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.53 kB 8.53 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
index.html gzip 561 B 561 B ✓
link.html gzip 569 B 569 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
buildDuration 13s 13.1s ⚠️ +120ms
buildDurationCached 3.7s 4.2s ⚠️ +415ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +519 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.53 kB 8.53 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
buildDuration 10.1s 10.2s ⚠️ +100ms
buildDurationCached 4.3s 4.2s -113ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +519 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.939 2.081 ⚠️ +0.14
/ avg req/sec 1289.27 1201.6 ⚠️ -87.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.093 1.158 ⚠️ +0.06
/error-in-render avg req/sec 2288.09 2158.83 ⚠️ -129.26
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.37 kB 9.37 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/disable-webpack-message-in-prod Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 6608b24

@timneutkens timneutkens merged commit 1cb4aaa into vercel:canary Jun 2, 2021
@timneutkens timneutkens deleted the fix/disable-webpack-message-in-prod branch June 2, 2021 09:19
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@timneutkens @kodiakhq
Don't show webpack version message in production server (vercel#25654)
0b81ff4 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@AriaMoradpour AriaMoradpour AriaMoradpour approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timneutkens @ijjk @AriaMoradpour