Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Plugin: Fix Document and Head import rules #25730

Merged
merged 1 commit into from Jun 7, 2021
Merged

ESLint Plugin: Fix Document and Head import rules #25730

merged 1 commit into from Jun 7, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

For #25548

@ijjk
Copy link
Member

ijjk commented Jun 2, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
buildDuration 15.4s 15.2s -171ms
buildDurationCached 4.1s 4s -100ms
nodeModulesSize 46.7 MB 46.7 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
/ failed reqs 0 0
/ total time (seconds) 2.733 2.731 0
/ avg req/sec 914.63 915.25 +0.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.584 1.625 ⚠️ +0.04
/error-in-render avg req/sec 1578.07 1538.15 ⚠️ -39.92
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.5 kB 19.5 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 59.5 kB 59.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.07 kB 3.07 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
_buildManifest.js gzip 392 B 392 B
Overall change 392 B 392 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
index.html gzip 559 B 559 B
link.html gzip 568 B 568 B
withRouter.html gzip 556 B 556 B
Overall change 1.68 kB 1.68 kB

Serverless Mode
General
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
buildDuration 17.1s 17.5s ⚠️ +342ms
buildDurationCached 5.3s 5.2s -43ms
nodeModulesSize 46.7 MB 46.7 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.5 kB 19.5 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 59.5 kB 59.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.07 kB 3.07 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
_buildManifest.js gzip 392 B 392 B
Overall change 392 B 392 B
Serverless bundles
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
_error.js 16.9 kB 16.9 kB
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 17.2 kB 17.2 kB
link.js 17.4 kB 17.4 kB
routerDirect.js 17.4 kB 17.4 kB
withRouter.js 17.4 kB 17.4 kB
Overall change 107 kB 107 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
buildDuration 13.7s 13.3s -402ms
buildDurationCached 6s 6s -61ms
nodeModulesSize 46.7 MB 46.7 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
/ failed reqs 0 0
/ total time (seconds) 2.787 2.766 -0.02
/ avg req/sec 896.89 903.83 +6.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.597 1.612 ⚠️ +0.02
/error-in-render avg req/sec 1565.8 1550.85 ⚠️ -14.95
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.26 kB 7.26 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
_app-HASH.js gzip 1.07 kB 1.07 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.63 kB 1.63 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.16 kB 9.16 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js fix-document-head-import-eslint-rules Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB
Commit: 1d48240

@timneutkens timneutkens merged commit 8ae12db into vercel:canary Jun 7, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants