Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable split chunks in webpack 5 in dev mode #25735

Merged
merged 2 commits into from Jun 3, 2021
Merged

Disable split chunks in webpack 5 in dev mode #25735

merged 2 commits into from Jun 3, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 3, 2021 •
edited

Using split chunks can cause a chunks hash to unexpectedly change in development which can cause it to trigger a page reload unexpectedly since we detect changes for _document based on the chunk hash. This disables split chunks for webpack 5 in dev mode until we update handling to check for changes in a different way.

x-ref: #25434

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the type: next label Jun 3, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Jun 3, 2021

Stats from current PR

Default Server Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
buildDuration 11.5s 11.4s -59ms
buildDurationCached 3.1s 3.1s -42ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +32 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.057 2.044 -0.01
/ avg req/sec 1215.32 1223.02 +7.7
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.075 1.077 0
/error-in-render avg req/sec 2325.89 2320.44 ⚠️ -5.45
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.5 kB 19.5 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
index.html gzip 559 B 559 B ✓
link.html gzip 568 B 568 B ✓
withRouter.html gzip 556 B 556 B ✓
Overall change 1.68 kB 1.68 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
buildDuration 13s 13.1s ⚠️ +53ms
buildDurationCached 4.1s 4.1s ⚠️ +3ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +32 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.5 kB 19.5 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
buildDuration 10.4s 10.4s ⚠️ +22ms
buildDurationCached 4.5s 4.4s -92ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +32 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.094 2.107 ⚠️ +0.01
/ avg req/sec 1194.05 1186.76 ⚠️ -7.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.037 1.082 ⚠️ +0.05
/error-in-render avg req/sec 2411.2 2309.6 ⚠️ -101.6
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.16 kB 9.16 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/wp5-dev-reload Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 4e94081

@timneutkens timneutkens marked this pull request as ready for review June 3, 2021 11:40
@kodiakhq kodiakhq bot merged commit 5bbcc9e into vercel:canary Jun 3, 2021
@ijjk ijjk mentioned this pull request Jun 3, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@ijjk
Disable split chunks in webpack 5 in dev mode (vercel#25735)
35c577d 
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @timneutkens