Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump "engines" to node >= 12.0.0 #25761

Merged
merged 3 commits into from Jun 3, 2021
Merged

Bump "engines" to node >= 12.0.0 #25761

merged 3 commits into from Jun 3, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Jun 3, 2021 •
edited

Node.js 10 has reach end-of-life and is no longer supported so we now target Node.js 12 or newer.

https://nodejs.org/en/about/releases/

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: next labels Jun 3, 2021
@ijjk
Copy link
Member

ijjk commented Jun 3, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
buildDuration 11s 11.1s ⚠️ +62ms
buildDurationCached 2.8s 2.7s -109ms
nodeModulesSize 46.7 MB 46.7 MB -1 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.308 2.269 -0.04
/ avg req/sec 1083.36 1101.91 +18.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.193 1.15 -0.04
/error-in-render avg req/sec 2094.7 2174.8 +80.1
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
index.html gzip 573 B 573 B ✓
link.html gzip 580 B 580 B ✓
withRouter.html gzip 568 B 568 B ✓
Overall change 1.72 kB 1.72 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
buildDuration 12.3s 12.7s ⚠️ +342ms
buildDurationCached 3.8s 3.7s -110ms
nodeModulesSize 46.7 MB 46.7 MB -1 B
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
_error.js 16.9 kB 16.9 kB -2 B
404.html 2.44 kB 2.44 kB ✓
500.html 2.43 kB 2.43 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.63 kB ✓
css.html 1.81 kB 1.81 kB ✓
hooks.html 1.69 kB 1.69 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB -2 B
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
buildDuration 10s 9.7s -271ms
buildDurationCached 4s 4s ⚠️ +35ms
nodeModulesSize 46.7 MB 46.7 MB -1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.229 2.341 ⚠️ +0.11
/ avg req/sec 1121.61 1067.91 ⚠️ -53.7
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.123 1.224 ⚠️ +0.1
/error-in-render avg req/sec 2226.87 2042.79 ⚠️ -184.08
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.16 kB 9.16 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bump-engines-node-12 Change
index.html gzip 626 B 626 B ✓
link.html gzip 632 B 632 B ✓
withRouter.html gzip 620 B 620 B ✓
Overall change 1.88 kB 1.88 kB ✓
Commit: cc5abb8

@ijjk ijjk merged commit 3ae27a8 into canary Jun 3, 2021
@ijjk ijjk deleted the bump-engines-node-12 branch June 3, 2021 22:21
@matamatanot matamatanot mentioned this pull request Jun 4, 2021
Merged
1 task
kodiakhq bot pushed a commit that referenced this pull request Jun 4, 2021
@matamatanot
Replace 'require' with 'import' in bench files and update dependancies (
c922c6a 
#25775)

## Feature

- [ ] Telemetry added. In case of a feature if it's used or not.

### Replace 'require' with 'import' in bench files
Node.js 12 allows you to use `import`.

### Update dependancies
https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md#breaking-changes

> Require Node.js v12+

For #25761, Node.js 12 is required. Therefore, there is no problem updating it. For benchmarking purposes, it would be reasonable to update to the latest version.
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@styfle
Bump "engines" to node >= 12.0.0 (vercel#25761)
37e6ff2 
* Bump "engines" to node >= 12.0.0

* Bump next-stats-action

* Rename azure groups
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@matamatanot
Replace 'require' with 'import' in bench files and update dependancies (
3652b7e 
vercel#25775)

## Feature

- [ ] Telemetry added. In case of a feature if it's used or not.

### Replace 'require' with 'import' in bench files
Node.js 12 allows you to use `import`.

### Update dependancies
https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md#breaking-changes

> Require Node.js v12+

For vercel#25761, Node.js 12 is required. Therefore, there is no problem updating it. For benchmarking purposes, it would be reasonable to update to the latest version.
@styfle styfle mentioned this pull request Jul 13, 2021
Merged
kodiakhq bot pushed a commit that referenced this pull request Jul 13, 2021
@styfle
Bump babel target to Node.js 12 (#27147)
f9001b9 
Next.js 11 supports Node.js 12 and newer. This PR updates babel to reflect this.

Follow up to PR #25761
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@styfle
Bump babel target to Node.js 12 (vercel#27147)
1b10fb3 
Next.js 11 supports Node.js 12 and newer. This PR updates babel to reflect this.

Follow up to PR vercel#25761
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@styfle @ijjk