Bump minimum React version to `^17.0.2` #25788

devknoll · 2021-06-04T17:42:27Z

Bump the minimum React version and update some deps. Note that there's still compatibility code to remove and type definitions to update, but I'll do that in a follow up.

ijjk · 2021-06-04T18:17:32Z

Failing test suites

Commit: 17c3a6a

test/integration/basepath/test/index.test.js

basePath development > should render error in dev overlay correctly

Expand output

● basePath development › should render error in dev overlay correctly

ElementNotInteractableError: element not interactable
  (Session info: headless chrome=91.0.4472.77)

  401 |     it('should render error in dev overlay correctly', async () => {
  402 |       const browser = await webdriver(appPort, `${basePath}/hello`)
> 403 |       await browser.elementByCss('#trigger-error').click()
      |       ^
  404 |       expect(await hasRedbox(browser)).toBe(true)
  405 |
  406 |       const errorSource = await getRedboxSource(browser)

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.<anonymous> (integration/basepath/test/index.test.js:403:7)

ijjk · 2021-06-06T18:59:56Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
buildDuration	14.6s	14.8s	⚠️ +133ms
buildDurationCached	3.5s	3.5s	-69ms
nodeModulesSize	46.6 MB	46.7 MB	⚠️ +24.7 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.879	2.901	⚠️ +0.02
/ avg req/sec	868.43	861.64	⚠️ -6.79
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.724	1.709	-0.01
/error-in-render avg req/sec	1450.26	1463.16	+12.9

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.07 kB	3.07 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	333 B	333 B	✓
withRouter-HASH.js gzip	330 B	330 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
_buildManifest.js gzip	392 B	392 B	✓
Overall change	392 B	392 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
index.html gzip	571 B	571 B	✓
link.html gzip	579 B	579 B	✓
withRouter.html gzip	567 B	567 B	✓
Overall change	1.72 kB	1.72 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
buildDuration	16.8s	16.6s	-154ms
buildDurationCached	4.8s	4.7s	-99ms
nodeModulesSize	46.6 MB	46.7 MB	⚠️ +24.7 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.07 kB	3.07 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	333 B	333 B	✓
withRouter-HASH.js gzip	330 B	330 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
_buildManifest.js gzip	392 B	392 B	✓
Overall change	392 B	392 B	✓

Serverless bundles

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	2.44 kB	2.44 kB	✓
500.html	2.43 kB	2.43 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.63 kB	1.63 kB	✓
css.html	1.81 kB	1.81 kB	✓
hooks.html	1.69 kB	1.69 kB	✓
index.js	17.2 kB	17.2 kB	✓
link.js	17.4 kB	17.4 kB	✓
routerDirect.js	17.4 kB	17.4 kB	✓
withRouter.js	17.4 kB	17.4 kB	✓
Overall change	107 kB	107 kB	✓

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
buildDuration	13s	13.1s	⚠️ +146ms
buildDurationCached	5.2s	5.1s	-76ms
nodeModulesSize	46.6 MB	46.7 MB	⚠️ +24.7 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.933	2.931	0
/ avg req/sec	852.26	852.96	+0.7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.743	1.772	⚠️ +0.03
/error-in-render avg req/sec	1433.99	1410.9	⚠️ -23.09

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
677f882d2ed8..HASH.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.99 kB	7.99 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	61.1 kB	61.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
_app-HASH.js gzip	1.07 kB	1.07 kB	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.63 kB	1.63 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.16 kB	9.16 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js bump-min-react-17	Change
index.html gzip	626 B	626 B	✓
link.html gzip	632 B	632 B	✓
withRouter.html gzip	620 B	620 B	✓
Overall change	1.88 kB	1.88 kB	✓

Commit: 3cf96e8

devknoll added 2 commits June 4, 2021 17:36

Bump minimum React version to ^17.0.2

57847c2

Merge branch 'canary' into bump-min-react-17

17c3a6a

ijjk added the type: next label Jun 4, 2021

This comment has been minimized.

Sign in to view

devknoll marked this pull request as ready for review June 4, 2021 17:53

devknoll requested review from divmain, ijjk, lfades, shuding and timneutkens as code owners June 4, 2021 17:53

Revert react-refresh change for now

4c67654

This comment has been minimized.

Sign in to view

Remove React 16 tests

f7d08dd

This comment has been minimized.

Sign in to view

devknoll added 2 commits June 6, 2021 18:46

Fix yarn

88ae833

Merge branch 'canary' into bump-min-react-17

3cf96e8

timneutkens merged commit a09425f into vercel:canary Jun 7, 2021

timneutkens deleted the bump-min-react-17 branch June 7, 2021 11:11

sync-by-unito bot mentioned this pull request Jun 16, 2021

chore(deps): bump next from 10.1.2 to 11.0.0 filecoin-project/slate#793

Closed

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021

Bump minimum React version to ^17.0.2 (vercel#25788)

e4f6f23

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump minimum React version to `^17.0.2` #25788

Bump minimum React version to `^17.0.2` #25788

devknoll commented Jun 4, 2021 •

edited

This comment has been minimized.

ijjk commented Jun 4, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 6, 2021

Bump minimum React version to ^17.0.2 #25788

Bump minimum React version to ^17.0.2 #25788

Conversation

devknoll commented Jun 4, 2021 • edited

This comment has been minimized.

ijjk commented Jun 4, 2021

Failing test suites

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 6, 2021

Stats from current PR

Bump minimum React version to `^17.0.2` #25788

Bump minimum React version to `^17.0.2` #25788

devknoll commented Jun 4, 2021 •

edited