Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @types/comment-json #25810

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Remove @types/comment-json #25810

merged 2 commits into from
Jun 9, 2021

Conversation

matamatanot
Copy link
Contributor

Refactor

Remove type definition

https://github.com/kaelzhang/node-comment-json#install

Since 2.4.1, comment-json contains typescript declarations, so you might as well remove @types/comment-json.

@ijjk ijjk added the type: next label Jun 5, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jun 5, 2021

Failing test suites

Commit: da657fa

test/integration/rewrite-with-browser-history/test/index.test.js

  • rewrites persist with browser history actions > dev mode > back-button should go back to rewritten path successfully
Expand output

● rewrites persist with browser history actions › dev mode › back-button should go back to rewritten path successfully

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"#another"}
  (Session info: headless chrome=91.0.4472.77)

  33 |     await browser.back()
  34 |
> 35 |     expect(await browser.elementByCss('#another').text()).toBe('another page')
     |            ^
  36 |
  37 |     expect(await browser.eval('window.beforeNav')).toBe(1)
  38 |   })

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.<anonymous> (integration/rewrite-with-browser-history/test/index.test.js:35:12)

@ijjk
Copy link
Member

ijjk commented Jun 9, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
buildDuration 12.5s 12.7s ⚠️ +243ms
buildDurationCached 3.1s 3.2s ⚠️ +96ms
nodeModulesSize 46.5 MB 46.5 MB -36 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.498 2.482 -0.02
/ avg req/sec 1000.84 1007.2 +6.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.273 1.33 ⚠️ +0.06
/error-in-render avg req/sec 1963.51 1879.01 ⚠️ -84.5
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
index.html gzip 572 B 572 B ✓
link.html gzip 581 B 581 B ✓
withRouter.html gzip 568 B 568 B ✓
Overall change 1.72 kB 1.72 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
buildDuration 14.7s 14.6s -107ms
buildDurationCached 4.3s 4.4s ⚠️ +75ms
nodeModulesSize 46.5 MB 46.5 MB -36 B
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.44 kB 2.44 kB ✓
500.html 2.43 kB 2.43 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.63 kB ✓
css.html 1.81 kB 1.81 kB ✓
hooks.html 1.69 kB 1.69 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
buildDuration 11.5s 11.5s -41ms
buildDurationCached 4.8s 4.5s -263ms
nodeModulesSize 46.5 MB 46.5 MB -36 B
Page Load Tests Overall increase ✓
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.66 2.603 -0.06
/ avg req/sec 939.77 960.43 +20.66
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.312 1.299 -0.01
/error-in-render avg req/sec 1905.05 1924.86 +19.81
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.17 kB 9.17 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary matamatanot/next.js remove-types-comment-json Change
index.html gzip 626 B 626 B ✓
link.html gzip 632 B 632 B ✓
withRouter.html gzip 619 B 619 B ✓
Overall change 1.88 kB 1.88 kB ✓
Commit: f3723da

@timneutkens timneutkens merged commit f443b69 into vercel:canary Jun 9, 2021
@matamatanot matamatanot deleted the remove-types-comment-json branch June 9, 2021 12:59
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@matamatanot
Remove @types/comment-json (vercel#25810)
9358d8b
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matamatanot @ijjk @timneutkens