Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with-eslint example. #25817

Merged
merged 2 commits into from Jun 20, 2021
Merged

Conversation

leerob
Copy link
Member

@leerob leerob commented Jun 5, 2021

This is dependent on the docs going live. This example also needs updated – should I just open an issue?

https://github.com/vercel/next.js/tree/canary/examples/with-typescript-eslint-jest

@ijjk ijjk added the examples Issue/PR related to examples label Jun 5, 2021
@leerob leerob marked this pull request as ready for review June 20, 2021 21:06
Copy link
Member Author

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, all tests passing, going ahead and merging!

@leerob leerob merged commit eac0374 into vercel:canary Jun 20, 2021
@leerob leerob deleted the update-eslint-example branch June 20, 2021 21:16
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
bordeo pushed a commit to bordeo/next.js that referenced this pull request Jul 12, 2021
v11.0.1

* tag 'v11.0.1': (374 commits)
  v11.0.1
  v11.0.1-canary.8
  Ensure image-types file is included (vercel#26495)
  Strongly type `Router.events.on` and `Router.events.off` (vercel#26456)
  v11.0.1-canary.7
  Update i18n fields in docs (vercel#26492)
  Update to only add image import types when enabled (vercel#26485)
  Fix domain locales not available on client (vercel#26083)
  chore: Add Alex to lint documentation (vercel#26354)
  fix: ignore invalid accept-language header (vercel#26476)
  Add module.exports to security headers documentation (vercel#26466)
  (examples/with-webassembly) fixed for webpack 5 (vercel#26440)
  Add check for startLatency in fast refresh (vercel#26417)
  v11.0.1-canary.6
  docs(router.md) Add note about page state and navigation (vercel#26320)
  Remove period for ESLint `passHref` docs link. (vercel#26402)
  Update with-eslint example. (vercel#25817)
  Docs: Add Prettier section on ESLint page (vercel#26347)
  add missing closing bracket (vercel#26375)
  Improve the `next/script` documentation. (vercel#26325)
  ...
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants