Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: have .tsx be in ts template for create-next-app #25820

Merged
merged 3 commits into from Jun 7, 2021
Merged

feat: have .tsx be in ts template for create-next-app #25820

merged 3 commits into from Jun 7, 2021

Conversation

gleich
Copy link
Contributor

@gleich gleich commented Jun 5, 2021

Signed-off-by: Matthew Gleich git@mattglei.ch

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@gleich
feat: have .tsx be in ts template
4e75a90 
Signed-off-by: Matthew Gleich <git@mattglei.ch>
@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jun 5, 2021
timneutkens
timneutkens approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Jun 7, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary gleich/next.js canary Change
buildDuration 13s 13.3s ⚠️ +230ms
buildDurationCached 3.2s 3.2s -23ms
nodeModulesSize 46.7 MB 46.7 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary gleich/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.578 2.612 ⚠️ +0.03
/ avg req/sec 969.93 957.13 ⚠️ -12.8
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.361 1.37 ⚠️ +0.01
/error-in-render avg req/sec 1837.14 1825.31 ⚠️ -11.83
Client Bundles (main, webpack, commons)
vercel/next.js canary gleich/next.js canary Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary gleich/next.js canary Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary gleich/next.js canary Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary gleich/next.js canary Change
_buildManifest.js gzip 391 B 391 B ✓
Overall change 391 B 391 B ✓
Rendered Page Sizes
vercel/next.js canary gleich/next.js canary Change
index.html gzip 572 B 572 B ✓
link.html gzip 579 B 579 B ✓
withRouter.html gzip 567 B 567 B ✓
Overall change 1.72 kB 1.72 kB ✓
Serverless Mode
General
vercel/next.js canary gleich/next.js canary Change
buildDuration 14.9s 14.2s -654ms
buildDurationCached 4.3s 4.3s ⚠️ +77ms
nodeModulesSize 46.7 MB 46.7 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary gleich/next.js canary Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary gleich/next.js canary Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary gleich/next.js canary Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary gleich/next.js canary Change
_buildManifest.js gzip 391 B 391 B ✓
Overall change 391 B 391 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary gleich/next.js canary Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.44 kB 2.44 kB ✓
500.html 2.43 kB 2.43 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.63 kB ✓
css.html 1.81 kB 1.81 kB ✓
hooks.html 1.69 kB 1.69 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ⚠️ +2 B
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ⚠️ +2 B
Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary gleich/next.js canary Change
buildDuration 11.4s 11.2s -288ms
buildDurationCached 4.5s 4.7s ⚠️ +136ms
nodeModulesSize 46.7 MB 46.7 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary gleich/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.676 2.519 -0.16
/ avg req/sec 934.38 992.53 +58.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.349 1.305 -0.04
/error-in-render avg req/sec 1853.37 1916.32 +62.95
Client Bundles (main, webpack, commons)
vercel/next.js canary gleich/next.js canary Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary gleich/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary gleich/next.js canary Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.16 kB 9.16 kB ✓
Client Build Manifests
vercel/next.js canary gleich/next.js canary Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary gleich/next.js canary Change
index.html gzip 627 B 627 B ✓
link.html gzip 633 B 633 B ✓
withRouter.html gzip 620 B 620 B ✓
Overall change 1.88 kB 1.88 kB ✓
Commit: ca738c2

@ijjk
Copy link
Member

ijjk commented Jun 7, 2021

Failing test suites

Commit: ca738c2

test/integration/rewrite-with-browser-history/test/index.test.js

  • rewrites persist with browser history actions > dev mode > back-button should go back to rewritten path successfully
Expand output

● rewrites persist with browser history actions › dev mode › back-button should go back to rewritten path successfully

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"#another"}
  (Session info: headless chrome=91.0.4472.77)

  33 |     await browser.back()
  34 |
> 35 |     expect(await browser.elementByCss('#another').text()).toBe('another page')
     |            ^
  36 |
  37 |     expect(await browser.eval('window.beforeNav')).toBe(1)
  38 |   })

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.<anonymous> (integration/rewrite-with-browser-history/test/index.test.js:35:12)

@timneutkens timneutkens merged commit 7d02abc into vercel:canary Jun 7, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@gleich @kodiakhq @timneutkens
feat: have .tsx be in ts template for create-next-app (vercel#25820)
a91b746 
Signed-off-by: Matthew Gleich <git@mattglei.ch>

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gleich @ijjk @timneutkens