Add run on Google Cloud Run button to the docker example #25824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geshan
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
leerob
reviewed
Jun 6, 2021
- [x] Accept changes for the cloud run button line
leerob
reviewed
Jun 7, 2021
leerob
reviewed
Jun 7, 2021
leerob
approved these changes
Jun 7, 2021
geshan
commented
Jun 8, 2021
examples/with-docker/Dockerfile
Outdated
| @@ -3,8 +3,8 @@ FROM node:14-alpine AS deps | |||
| # Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed. | |||
| RUN apk add --no-cache libc6-compat | |||
| WORKDIR /app | |||
| COPY package.json ./ | |||
| RUN yarn install | |||
| COPY package.json yarn.lock ./ | |||
There was a problem hiding this comment.
Hey @leerob , thank you for merging this PR.
If yarn.lock is added back on this line it will result in the following docker build output:
If it is expected to run yarn on this folder before running docker build, it was not found it in the readme. In addition, a CI system say, Travis might just have docker and no node. I am not sure if this is what is intended. Happy to hear your thoughts!
There was a problem hiding this comment.
You can edit your code after cloning, but specifically for this example, we don't want the lockfile 👍
There was a problem hiding this comment.
Yes, so in this case the lock file shouldn't be referenced in the dockerfile too then?
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 16, 2021
## Documentation / Examples - [x] Make sure the linting passes ### Deployed with Cloud Run Button <img width="1075" alt="Screen Shot 2021-06-06 at 10 22 51 pm" src="https://user-images.githubusercontent.com/170554/120924210-d7946780-c715-11eb-889e-79679f795c54.png"> ### Next.js working on Google Cloud Run <img width="982" alt="Screen Shot 2021-06-06 at 10 23 10 pm" src="https://user-images.githubusercontent.com/170554/120924229-e418c000-c715-11eb-9aca-569923f7306d.png">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation / Examples
Deployed with Cloud Run Button
Next.js working on Google Cloud Run