Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on adding HTTP security headers. #25833

Merged
merged 11 commits into from Jun 18, 2021
Merged

Conversation

leerob
Copy link
Member

@leerob leerob commented Jun 6, 2021

This document shows how to add HTTP response headers to your Next.js application to improve its security.

mrmckeb
mrmckeb previously approved these changes Jun 7, 2021
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - a few suggestions, but amazing work!

docs/advanced-features/security-headers.md Outdated Show resolved Hide resolved
docs/advanced-features/security-headers.md Outdated Show resolved Hide resolved
docs/advanced-features/security-headers.md Outdated Show resolved Hide resolved
docs/advanced-features/security-headers.md Outdated Show resolved Hide resolved
@leerob
Copy link
Member Author

leerob commented Jun 18, 2021

@styfle ready for re-review 😄

Co-authored-by: Steven <steven@ceriously.com>
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@styfle styfle requested a review from mrmckeb June 18, 2021 15:03
@leerob leerob merged commit ffaa481 into vercel:canary Jun 18, 2021
@leerob leerob deleted the security-headers branch June 18, 2021 17:34
// Apply these headers to all routes in your application.
source: '/(.*)',
headers: securityHeaders
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, array closing bracket is missing here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, would you like to submit a PR to fix it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@styfle Hi sure , just submitted pull request here: #26375

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants