Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for older TypeScript versions #25867

Merged
merged 2 commits into from Jun 8, 2021
Merged

Add warning for older TypeScript versions #25867

merged 2 commits into from Jun 8, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 7, 2021

This adds a warning when older TypeScript versions are used as there can be incompatibilities with newer types used in Next.js and older versions aren't compatible with incremental type checking

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the type: next label Jun 7, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Jun 7, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
buildDuration 13.5s 12.8s -759ms
buildDurationCached 3.5s 3.1s -374ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +816 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.637 2.502 -0.14
/ avg req/sec 948.22 999.32 +51.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.451 1.302 -0.15
/error-in-render avg req/sec 1723.25 1919.43 +196.18
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
_buildManifest.js gzip 391 B 391 B ✓
Overall change 391 B 391 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
index.html gzip 572 B 572 B ✓
link.html gzip 579 B 579 B ✓
withRouter.html gzip 567 B 567 B ✓
Overall change 1.72 kB 1.72 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
buildDuration 15.3s 14.1s -1.3s
buildDurationCached 4.3s 4.2s -116ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +816 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
_buildManifest.js gzip 391 B 391 B ✓
Overall change 391 B 391 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.44 kB 2.44 kB ✓
500.html 2.43 kB 2.43 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.63 kB ✓
css.html 1.81 kB 1.81 kB ✓
hooks.html 1.69 kB 1.69 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
buildDuration 12.2s 10.8s -1.4s
buildDurationCached 4.5s 5.1s ⚠️ +629ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +816 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.537 2.616 ⚠️ +0.08
/ avg req/sec 985.57 955.61 ⚠️ -29.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.26 1.488 ⚠️ +0.23
/error-in-render avg req/sec 1984.72 1680.53 ⚠️ -304.19
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.16 kB 9.16 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/typescript-version-warn Change
index.html gzip 627 B 627 B ✓
link.html gzip 633 B 633 B ✓
withRouter.html gzip 620 B 620 B ✓
Overall change 1.88 kB 1.88 kB ✓
Commit: df7f1b4

@timneutkens timneutkens merged commit 583b5b9 into vercel:canary Jun 8, 2021
@timneutkens timneutkens deleted the add/typescript-version-warn branch June 8, 2021 07:21
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@ijjk
Add warning for older TypeScript versions (vercel#25867)
4c3e8a3
@UnPolinomio UnPolinomio mentioned this pull request Jun 16, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @timneutkens