Prevent node inspect from causing webpack check to fail #25876

ijjk · 2021-06-08T00:55:16Z

This fixes a case where starting next dev with NODE_OPTIONS='--inspect' set in the environment causes the webpack version check to fail silently. This seems to only affect node 12 and not node 14 as it seems the address already in use error in node is only fatal in older versions.

We might want to also override the NODE_OPTIONS env when starting our static check workers, export workers, and dev static paths workers.

Bug

Related issues linked using fixes #number
Integration tests added

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

Make sure the linting passes

ijjk · 2021-06-08T01:07:12Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
buildDuration	14.2s	14.3s	⚠️ +81ms
buildDurationCached	3.4s	3.5s	⚠️ +77ms
nodeModulesSize	46.7 MB	46.7 MB	⚠️ +411 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.844	2.824	-0.02
/ avg req/sec	878.93	885.12	+6.19
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.667	1.623	-0.04
/error-in-render avg req/sec	1499.52	1540.35	+40.83

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.07 kB	3.07 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	333 B	333 B	✓
withRouter-HASH.js gzip	330 B	330 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
_buildManifest.js gzip	391 B	391 B	✓
Overall change	391 B	391 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
index.html gzip	572 B	572 B	✓
link.html gzip	579 B	579 B	✓
withRouter.html gzip	566 B	566 B	✓
Overall change	1.72 kB	1.72 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
buildDuration	16s	16s	-48ms
buildDurationCached	4.7s	4.7s	-1ms
nodeModulesSize	46.7 MB	46.7 MB	⚠️ +411 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.07 kB	3.07 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	333 B	333 B	✓
withRouter-HASH.js gzip	330 B	330 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
_buildManifest.js gzip	391 B	391 B	✓
Overall change	391 B	391 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	2.44 kB	2.44 kB	✓
500.html	2.43 kB	2.43 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.63 kB	1.63 kB	✓
css.html	1.81 kB	1.81 kB	✓
hooks.html	1.69 kB	1.69 kB	✓
index.js	17.2 kB	17.2 kB	✓
link.js	17.4 kB	17.4 kB	✓
routerDirect.js	17.4 kB	17.4 kB	✓
withRouter.js	17.4 kB	17.4 kB	✓
Overall change	107 kB	107 kB	✓

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
buildDuration	12.4s	12.4s	-26ms
buildDurationCached	5.1s	5.1s	-68ms
nodeModulesSize	46.7 MB	46.7 MB	⚠️ +411 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.921	2.893	-0.03
/ avg req/sec	855.73	864.15	+8.42
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.655	1.597	-0.06
/error-in-render avg req/sec	1510.42	1564.97	+54.55

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
677f882d2ed8..HASH.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.99 kB	7.99 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	61.1 kB	61.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
_app-HASH.js gzip	1.07 kB	1.07 kB	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.63 kB	1.63 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.16 kB	9.16 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/node-opts-config-check	Change
index.html gzip	627 B	627 B	✓
link.html gzip	632 B	632 B	✓
withRouter.html gzip	621 B	621 B	✓
Overall change	1.88 kB	1.88 kB	✓

Commit: d6e2fe3

Prevent node inspect from causing webpack check to fail

d6e2fe3

ijjk requested review from divmain, lfades, shuding and timneutkens as code owners June 8, 2021 00:55

ijjk added the type: next label Jun 8, 2021

timneutkens approved these changes Jun 8, 2021

View reviewed changes

timneutkens merged commit 18f8198 into vercel:canary Jun 8, 2021

timneutkens deleted the fix/node-opts-config-check branch June 8, 2021 07:23

sync-by-unito bot mentioned this pull request Jun 16, 2021

chore(deps): bump next from 10.1.2 to 11.0.0 filecoin-project/slate#793

Closed

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021

Prevent node inspect from causing webpack check to fail (vercel#25876)

d7c8006

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent node inspect from causing webpack check to fail #25876

Prevent node inspect from causing webpack check to fail #25876

ijjk commented Jun 8, 2021

ijjk commented Jun 8, 2021

Prevent node inspect from causing webpack check to fail #25876

Prevent node inspect from causing webpack check to fail #25876

Conversation

ijjk commented Jun 8, 2021

Bug

Feature

Documentation / Examples

ijjk commented Jun 8, 2021

Stats from current PR