Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loader url composition on image/next doc #25893

Merged
merged 3 commits into from Jun 10, 2021
Merged

Fix loader url composition on image/next doc #25893

merged 3 commits into from Jun 10, 2021

Conversation

valse
Copy link
Contributor

@valse valse commented Jun 8, 2021

Remove the extra slash to avoid double slashes on returned url (the image src prop needs to start with a slash)

Remove the extra slash to avoid double slashes on returned url (the image src prop needs to start with a slash)
@leerob
Copy link
Member

leerob commented Jun 8, 2021

the image src prop needs to start with a slash

Could you link to this? 🙏

@valse
Copy link
Contributor Author

valse commented Jun 9, 2021

the image src prop needs to start with a slash

Could you link to this? 🙏

I'm confused with the default loader and I saw that the build in ones normalize the extra slash.

However the example in the doc add a double slash: I edited removing it from from the src attribute instead of in the loader function

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, okay I see what you meant now. Thank you!

@kodiakhq kodiakhq bot merged commit 7f25ec4 into vercel:canary Jun 10, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
Remove the extra slash to avoid double slashes on returned url (the image src prop needs to start with a slash)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants