Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove opentelemetry/api #25900

Merged
merged 2 commits into from Jun 8, 2021
Merged

remove opentelemetry/api #25900

merged 2 commits into from Jun 8, 2021

Conversation

turneand
Copy link
Contributor

@turneand turneand commented Jun 8, 2021

Bug

Resolves the issue #21861 by simply removing the opentelemetry/api dependency, which does not appear to be required since #22713 was implemented.

Identified the same issue where implementing opentelemetry with the latest libraries causes conflicts with the api version included in nextjs.

No tests or code updated, as library was otherwise unused.
Please let me know if it's appropriate to remove and there's not some other reason it's included that I could not see

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine 👍 It was indeed removed.

@timneutkens timneutkens merged commit 535a83d into vercel:canary Jun 8, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants