Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add global callback for refresh latency #25944

Merged
merged 2 commits into from Jun 9, 2021
Merged

add global callback for refresh latency #25944

merged 2 commits into from Jun 9, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 9, 2021 •
edited

Adds latency information to the [Fast Refresh] done log in the console.

Also allows to visualize/track/log latency via a __NEXT_HMR_LATENCY_CB global.

@ijjk ijjk added the type: next label Jun 9, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@sokra sokra marked this pull request as ready for review June 9, 2021 16:54
@ijjk
Copy link
Member

ijjk commented Jun 9, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/latency-callback Change
buildDuration 14.2s 14.2s -13ms
buildDurationCached 3.5s 3.5s ⚠️ +1ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +663 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feat/latency-callback Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.846 2.995 ⚠️ +0.15
/ avg req/sec 878.44 834.62 ⚠️ -43.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.657 1.742 ⚠️ +0.08
/error-in-render avg req/sec 1508.68 1435.51 ⚠️ -73.17
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feat/latency-callback Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/latency-callback Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feat/latency-callback Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feat/latency-callback Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/latency-callback Change
index.html gzip 572 B 572 B ✓
link.html gzip 581 B 581 B ✓
withRouter.html gzip 568 B 568 B ✓
Overall change 1.72 kB 1.72 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/latency-callback Change
buildDuration 16.3s 16.5s ⚠️ +234ms
buildDurationCached 4.6s 4.5s -66ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +663 B
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feat/latency-callback Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/latency-callback Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feat/latency-callback Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feat/latency-callback Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/latency-callback Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.44 kB 2.44 kB ✓
500.html 2.43 kB 2.43 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.63 kB ✓
css.html 1.81 kB 1.81 kB ✓
hooks.html 1.69 kB 1.69 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ⚠️ +2 B
Overall change 107 kB 107 kB ⚠️ +2 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/latency-callback Change
buildDuration 12.5s 12.6s ⚠️ +109ms
buildDurationCached 5.2s 5.1s -119ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +663 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js feat/latency-callback Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.979 2.966 -0.01
/ avg req/sec 839.09 842.87 +3.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.704 1.64 -0.06
/error-in-render avg req/sec 1467.24 1524.29 +57.05
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feat/latency-callback Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/latency-callback Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feat/latency-callback Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.17 kB 9.17 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feat/latency-callback Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/latency-callback Change
index.html gzip 626 B 626 B ✓
link.html gzip 632 B 632 B ✓
withRouter.html gzip 619 B 619 B ✓
Overall change 1.88 kB 1.88 kB ✓
Commit: c283795

@timneutkens timneutkens merged commit 00c00f2 into canary Jun 9, 2021
@timneutkens timneutkens deleted the feat/latency-callback branch June 9, 2021 17:35
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@sokra @ijjk
add global callback for refresh latency (vercel#25944)
ac11129 
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sokra @ijjk @timneutkens