Update image documentation for static image #25949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds documentation for static image and blurry placeholder functionality
atcastle
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
styfle
reviewed
Jun 9, 2021
styfle
reviewed
Jun 9, 2021
styfle
reviewed
Jun 9, 2021
styfle
reviewed
Jun 9, 2021
styfle
reviewed
Jun 9, 2021
styfle
reviewed
Jun 9, 2021
styfle
requested changes
Jun 9, 2021
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Steven <steven@ceriously.com>
leerob
reviewed
Jun 9, 2021
docs/api-reference/next/image.md
Outdated
|
|
||
| function Home() { | ||
| return ( | ||
| <> | ||
| <h1>My Homepage</h1> | ||
| <Image | ||
| src="/me.png" | ||
| src={profilePic} |
There was a problem hiding this comment.
Should we show code examples of:
- Static Image
- Dynamic src (fetching from a CMS)
- Manually adding blurDataURL example?
There was a problem hiding this comment.
Perhaps, it could get busy.
We also need to update these pages:
https://nextjs.org/docs/basic-features/image-optimization
https://nextjs.org/docs/basic-features/static-file-serving
styfle
reviewed
Jun 9, 2021
styfle
reviewed
Jun 9, 2021
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
There are strict conditions for using `placeholder=blur` documented in #25949 but this will give the user a better understanding during `next dev` and links to the error. - Error when `placeholder=blur` and no `blurDataURL` - The Error for small images with `placeholder=blur` has been changed to a warning - Added support for blurring a webp image - Added error page linking to relevant docs
janicklas-ralph
pushed a commit
to janicklas-ralph/next.js
that referenced
this pull request
Jun 11, 2021
There are strict conditions for using `placeholder=blur` documented in vercel#25949 but this will give the user a better understanding during `next dev` and links to the error. - Error when `placeholder=blur` and no `blurDataURL` - The Error for small images with `placeholder=blur` has been changed to a warning - Added support for blurring a webp image - Added error page linking to relevant docs
Co-authored-by: Steven <steven@ceriously.com>
ijjk
previously approved these changes
Jun 15, 2021
styfle
previously approved these changes
Jun 15, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 16, 2021
There are strict conditions for using `placeholder=blur` documented in vercel#25949 but this will give the user a better understanding during `next dev` and links to the error. - Error when `placeholder=blur` and no `blurDataURL` - The Error for small images with `placeholder=blur` has been changed to a warning - Added support for blurring a webp image - Added error page linking to relevant docs
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 16, 2021
* Update image documentation for static image Adds documentation for static image and blurry placeholder functionality * Update docs/api-reference/next/image.md Co-authored-by: Steven <steven@ceriously.com> * Update docs/api-reference/next/image.md Co-authored-by: Steven <steven@ceriously.com> * Update docs/api-reference/next/image.md Co-authored-by: Steven <steven@ceriously.com> * Update docs/api-reference/next/image.md Co-authored-by: Steven <steven@ceriously.com> * Version history and placeholder revisions * Apply suggestions from code review Co-authored-by: Steven <steven@ceriously.com> * lint-fix Co-authored-by: Steven <steven@ceriously.com> Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for static image and blurry placeholder functionality