Remove React version checks and warnings that are no longer needed #25992

devknoll · 2021-06-10T17:44:00Z

Canary requires react@>=17.0.2, so we no longer need these checks.

ijjk · 2021-06-14T17:25:21Z

Failing test suites

Commit: 82b5875

test/integration/basic/test/index.test.js

Basic Features > should polyfill Node.js modules

Expand output

● Basic Features › should polyfill Node.js modules

thrown: "Exceeded timeout of 300000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  35 |   afterAll(() => killApp(context.server))
  36 |
> 37 |   it('should polyfill Node.js modules', async () => {
     |   ^
  38 |     const browser = await webdriver(context.appPort, '/node-browser-polyfills')
  39 |
  40 |     console.error({

  at integration/basic/test/index.test.js:37:3
  at Object.<anonymous> (integration/basic/test/index.test.js:18:1)

ijjk · 2021-06-14T19:11:32Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
buildDuration	10.3s	10.2s	-128ms
buildDurationCached	2.5s	2.5s	-43ms
nodeModulesSize	46.4 MB	46.4 MB	-7.33 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.864	1.921	⚠️ +0.06
/ avg req/sec	1341.1	1301.58	⚠️ -39.52
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.039	1.049	⚠️ +0.01
/error-in-render avg req/sec	2405.26	2383.32	⚠️ -21.94

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	63 kB	63 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.17 kB	3.17 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	329 B	329 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.41 kB	8.41 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
_buildManifest.js gzip	391 B	391 B	✓
Overall change	391 B	391 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
index.html gzip	522 B	522 B	✓
link.html gzip	535 B	535 B	✓
withRouter.html gzip	515 B	515 B	✓
Overall change	1.57 kB	1.57 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
buildDuration	11.7s	11.6s	-143ms
buildDurationCached	3.4s	3.3s	-87ms
nodeModulesSize	46.4 MB	46.4 MB	-7.33 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	63 kB	63 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.17 kB	3.17 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	329 B	329 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.41 kB	8.41 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
_buildManifest.js gzip	391 B	391 B	✓
Overall change	391 B	391 B	✓

Serverless bundles

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	1.98 kB	1.98 kB	✓
500.html	1.96 kB	1.96 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.17 kB	1.17 kB	✓
css.html	1.35 kB	1.35 kB	✓
hooks.html	1.23 kB	1.23 kB	✓
index.js	17.2 kB	17.2 kB	✓
link.js	17.5 kB	17.5 kB	✓
routerDirect.js	17.3 kB	17.3 kB	✓
withRouter.js	17.3 kB	17.3 kB	✓
Overall change	105 kB	105 kB	✓

Webpack 4 Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
buildDuration	9.6s	9.4s	-222ms
buildDurationCached	3.9s	3.8s	-145ms
nodeModulesSize	46.4 MB	46.4 MB	-7.33 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.009	2.094	⚠️ +0.08
/ avg req/sec	1244.37	1193.82	⚠️ -50.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.053	1.082	⚠️ +0.03
/error-in-render avg req/sec	2373.99	2311.13	⚠️ -62.86

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	41.8 kB	41.8 kB	✓
main-HASH.js gzip	7.99 kB	7.99 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	63.9 kB	63.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
_app-HASH.js gzip	1.07 kB	1.07 kB	✓
_error-HASH.js gzip	3.84 kB	3.84 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	333 B	333 B	✓
hooks-HASH.js gzip	910 B	910 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	295 B	295 B	✓
withRouter-HASH.js gzip	292 B	292 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.28 kB	9.28 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js remove-unnecessary-react-version-checks	Change
index.html gzip	568 B	568 B	✓
link.html gzip	580 B	580 B	✓
withRouter.html gzip	561 B	561 B	✓
Overall change	1.71 kB	1.71 kB	✓

Commit: e0e7472

…ercel#25992) Canary requires `react@>=17.0.2`, so we no longer need these checks.

Remove React version checks and warnings that are no longer needed

65da260

ijjk added the type: next label Jun 10, 2021

This comment has been minimized.

Sign in to view

devknoll added 2 commits June 14, 2021 16:42

Merge branch 'canary' into remove-unnecessary-react-version-checks

5050a55

Remove unnecessary React version tests

bb7b5ce

This comment has been minimized.

Sign in to view

devknoll added 2 commits June 14, 2021 17:01

Remove more unnecessary tests

82b5875

Update stats-app

826e39f

This comment has been minimized.

Sign in to view

Merge branch 'canary' into remove-unnecessary-react-version-checks

4ce09f8

This comment has been minimized.

Sign in to view

Merge branch 'canary' into remove-unnecessary-react-version-checks

e0e7472

devknoll marked this pull request as ready for review June 14, 2021 19:02

devknoll requested review from divmain, ijjk, lfades, shuding and timneutkens as code owners June 14, 2021 19:02

ijjk approved these changes Jun 14, 2021

View reviewed changes

kodiakhq bot merged commit 1ebf26a into vercel:canary Jun 14, 2021

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021

Remove React version checks and warnings that are no longer needed (v…

496665b

…ercel#25992) Canary requires `react@>=17.0.2`, so we no longer need these checks.

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove React version checks and warnings that are no longer needed #25992

Remove React version checks and warnings that are no longer needed #25992

devknoll commented Jun 10, 2021 •

edited

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 14, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 14, 2021

Remove React version checks and warnings that are no longer needed #25992

Remove React version checks and warnings that are no longer needed #25992

Conversation

devknoll commented Jun 10, 2021 • edited

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 14, 2021

Failing test suites

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 14, 2021

Stats from current PR

devknoll commented Jun 10, 2021 •

edited