Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitignore template to published files for codemod #26008

Merged
merged 1 commit into from Jun 11, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 11, 2021

Ensures this gitignore template is included in the published package since it is required at runtime.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member Author

ijjk commented Jun 11, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js codemod/extra-file Change
buildDuration 13s 12.8s -234ms
buildDurationCached 3.2s 3.2s -9ms
nodeModulesSize 46.5 MB 46.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js codemod/extra-file Change
/ failed reqs 0 0
/ total time (seconds) 2.562 2.581 ⚠️ +0.02
/ avg req/sec 975.81 968.74 ⚠️ -7.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.324 1.335 ⚠️ +0.01
/error-in-render avg req/sec 1888.25 1872.29 ⚠️ -15.96
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js codemod/extra-file Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js codemod/extra-file Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js codemod/extra-file Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.18 kB 3.18 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.43 kB 8.43 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js codemod/extra-file Change
_buildManifest.js gzip 395 B 395 B
Overall change 395 B 395 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js codemod/extra-file Change
index.html gzip 573 B 573 B
link.html gzip 580 B 580 B
withRouter.html gzip 568 B 568 B
Overall change 1.72 kB 1.72 kB

Serverless Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js codemod/extra-file Change
buildDuration 14.8s 14.6s -190ms
buildDurationCached 4.3s 4.2s -32ms
nodeModulesSize 46.5 MB 46.5 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js codemod/extra-file Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js codemod/extra-file Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js codemod/extra-file Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.18 kB 3.18 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.43 kB 8.43 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js codemod/extra-file Change
_buildManifest.js gzip 395 B 395 B
Overall change 395 B 395 B
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js codemod/extra-file Change
_error.js 16.9 kB 16.9 kB
404.html 2.44 kB 2.44 kB
500.html 2.43 kB 2.43 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.63 kB 1.63 kB
css.html 1.81 kB 1.81 kB
hooks.html 1.69 kB 1.69 kB
index.js 17.2 kB 17.2 kB -2 B
link.js 17.4 kB 17.4 kB
routerDirect.js 17.4 kB 17.4 kB
withRouter.js 17.4 kB 17.4 kB
Overall change 107 kB 107 kB -2 B

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js codemod/extra-file Change
buildDuration 11.6s 11.7s ⚠️ +157ms
buildDurationCached 4.7s 4.7s -37ms
nodeModulesSize 46.5 MB 46.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js codemod/extra-file Change
/ failed reqs 0 0
/ total time (seconds) 2.672 2.629 -0.04
/ avg req/sec 935.76 950.98 +15.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.306 1.31 0
/error-in-render avg req/sec 1914.67 1908.49 ⚠️ -6.18
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js codemod/extra-file Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.99 kB 7.99 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 61.1 kB 61.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js codemod/extra-file Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js codemod/extra-file Change
_app-HASH.js gzip 1.07 kB 1.07 kB
_error-HASH.js gzip 3.85 kB 3.85 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.63 kB 1.63 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.28 kB 9.28 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js codemod/extra-file Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js codemod/extra-file Change
index.html gzip 626 B 626 B
link.html gzip 633 B 633 B
withRouter.html gzip 620 B 620 B
Overall change 1.88 kB 1.88 kB
Commit: 30a5170

@timneutkens timneutkens merged commit 0a92063 into vercel:canary Jun 11, 2021
@timneutkens timneutkens deleted the codemod/extra-file branch June 11, 2021 15:51
janicklas-ralph pushed a commit to janicklas-ralph/next.js that referenced this pull request Jun 11, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants