Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Firefox image decode error #26011

Merged
merged 3 commits into from Jun 11, 2021
Merged

Fix Firefox image decode error #26011

merged 3 commits into from Jun 11, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 11, 2021 •
edited

This ensures the placeholder is removed correctly on second render in Firefox since it appears it rejects with DOMException: Invalid image request when we call img.decode() on the second render of an image. This only seems to occur in Firefox and not in Safari or Chrome.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

styfle
styfle previously approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! (See what I did there)

@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review June 11, 2021 16:44
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Jun 11, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
buildDuration 11.3s 11.3s ⚠️ +41ms
buildDurationCached 2.7s 2.8s ⚠️ +8ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +74 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.241 2.278 ⚠️ +0.04
/ avg req/sec 1115.66 1097.63 ⚠️ -18.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.133 1.148 ⚠️ +0.01
/error-in-render avg req/sec 2206.7 2178.46 ⚠️ -28.24
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.18 kB 3.18 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.43 kB 8.43 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
_buildManifest.js gzip 395 B 395 B ✓
Overall change 395 B 395 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
index.html gzip 573 B 573 B ✓
link.html gzip 580 B 580 B ✓
withRouter.html gzip 568 B 568 B ✓
Overall change 1.72 kB 1.72 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
buildDuration 12.8s 12.6s -150ms
buildDurationCached 3.7s 3.8s ⚠️ +94ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +74 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.18 kB 3.18 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.43 kB 8.43 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
_buildManifest.js gzip 395 B 395 B ✓
Overall change 395 B 395 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.44 kB 2.44 kB ✓
500.html 2.43 kB 2.43 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.63 kB ✓
css.html 1.81 kB 1.81 kB ✓
hooks.html 1.69 kB 1.69 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ⚠️ +2 B
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB -2 B
Overall change 107 kB 107 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
buildDuration 10.2s 9.9s -254ms
buildDurationCached 4.1s 4s -115ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +74 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.263 2.312 ⚠️ +0.05
/ avg req/sec 1104.56 1081.35 ⚠️ -23.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.142 1.155 ⚠️ +0.01
/error-in-render avg req/sec 2188.87 2164.51 ⚠️ -24.36
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.85 kB 3.85 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.28 kB 9.28 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/firefox-img-decode Change
index.html gzip 626 B 626 B ✓
link.html gzip 633 B 633 B ✓
withRouter.html gzip 620 B 620 B ✓
Overall change 1.88 kB 1.88 kB ✓
Commit: 6c1c5ae

@ijjk ijjk requested a review from styfle June 11, 2021 17:21
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk merged commit 6eb6e30 into vercel:canary Jun 11, 2021
@ijjk ijjk deleted the fix/firefox-img-decode branch June 11, 2021 17:58
janicklas-ralph pushed a commit to janicklas-ralph/next.js that referenced this pull request Jun 11, 2021
@ijjk @janicklas-ralph
Fix Firefox image decode error (vercel#26011)
f987f2f 
* Fix Firefox image decode error

* Add next/image test to production suite

* update page count test
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@ijjk
Fix Firefox image decode error (vercel#26011)
0e07a97 
* Fix Firefox image decode error

* Add next/image test to production suite

* update page count test
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @styfle