Ensure correct browser env is used #26014

ijjk · 2021-06-11T18:09:25Z

Looks like we had a typo in our workflow using BROWSERNAME env instead of BROWSER_NAME causing safari and firefox not to be used while testing in the specific browsers.

Bug

Related issues linked using fixes #number
Integration tests added

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

Make sure the linting passes

ijjk · 2021-06-11T19:05:37Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
buildDuration	13s	13.1s	⚠️ +69ms
buildDurationCached	3.3s	3.2s	-73ms
nodeModulesSize	46.5 MB	46.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.654	2.629	-0.02
/ avg req/sec	942.05	950.76	+8.71
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.383	1.3	-0.08
/error-in-render avg req/sec	1807.15	1923.38	+116.23

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.18 kB	3.18 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	333 B	333 B	✓
withRouter-HASH.js gzip	330 B	330 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.43 kB	8.43 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
_buildManifest.js gzip	395 B	395 B	✓
Overall change	395 B	395 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
index.html gzip	573 B	573 B	✓
link.html gzip	580 B	580 B	✓
withRouter.html gzip	568 B	568 B	✓
Overall change	1.72 kB	1.72 kB	✓

Serverless Mode

General

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
buildDuration	14.8s	14.9s	⚠️ +12ms
buildDurationCached	4.3s	4.4s	⚠️ +78ms
nodeModulesSize	46.5 MB	46.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.18 kB	3.18 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	333 B	333 B	✓
withRouter-HASH.js gzip	330 B	330 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.43 kB	8.43 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
_buildManifest.js gzip	395 B	395 B	✓
Overall change	395 B	395 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	2.44 kB	2.44 kB	✓
500.html	2.43 kB	2.43 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.63 kB	1.63 kB	✓
css.html	1.81 kB	1.81 kB	✓
hooks.html	1.69 kB	1.69 kB	✓
index.js	17.2 kB	17.2 kB	✓
link.js	17.4 kB	17.4 kB	✓
routerDirect.js	17.4 kB	17.4 kB	✓
withRouter.js	17.4 kB	17.4 kB	✓
Overall change	107 kB	107 kB	✓

Webpack 4 Mode (Increase detected ⚠️)

General

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
buildDuration	11.5s	11.4s	-39ms
buildDurationCached	4.8s	4.7s	-136ms
nodeModulesSize	46.5 MB	46.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.64	2.594	-0.05
/ avg req/sec	946.93	963.73	+16.8
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.423	1.314	-0.11
/error-in-render avg req/sec	1756.79	1902.9	+146.11

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.99 kB	7.99 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	61.1 kB	61.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
_app-HASH.js gzip	1.07 kB	1.07 kB	✓
_error-HASH.js gzip	3.85 kB	3.85 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.63 kB	1.63 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.28 kB	9.28 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/browser-env	Change
index.html gzip	626 B	626 B	✓
link.html gzip	633 B	633 B	✓
withRouter.html gzip	620 B	620 B	✓
Overall change	1.88 kB	1.88 kB	✓

Commit: 4229aaf

* Ensure correct browser env is used * Fix production suite in webpack 4 mode * fix page count on webpack 4

ijjk added 2 commits June 11, 2021 13:08

Ensure correct browser env is used

2d9ccf8

Merge remote-tracking branch 'upstream/canary' into fix/browser-env

cd18c03

ijjk requested review from divmain, lfades, shuding and timneutkens as code owners June 11, 2021 18:09

This comment has been minimized.

Sign in to view

Fix production suite in webpack 4 mode

0954eb5

styfle previously approved these changes Jun 11, 2021

View reviewed changes

fix page count on webpack 4

4229aaf

This comment has been minimized.

Sign in to view

ijjk dismissed styfle’s stale review via 4229aaf June 11, 2021 18:54

ijjk merged commit d257ef4 into vercel:canary Jun 11, 2021

ijjk deleted the fix/browser-env branch June 11, 2021 19:38

janicklas-ralph pushed a commit to janicklas-ralph/next.js that referenced this pull request Jun 11, 2021

Ensure correct browser env is used (vercel#26014)

a747cfe

* Ensure correct browser env is used * Fix production suite in webpack 4 mode * fix page count on webpack 4

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021

Ensure correct browser env is used (vercel#26014)

0b3754a

* Ensure correct browser env is used * Fix production suite in webpack 4 mode * fix page count on webpack 4

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure correct browser env is used #26014

Ensure correct browser env is used #26014

ijjk commented Jun 11, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 11, 2021

Ensure correct browser env is used #26014

Ensure correct browser env is used #26014

Conversation

ijjk commented Jun 11, 2021

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 11, 2021

Stats from current PR