Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(examples/with-lingui): update example #26076

Merged
merged 5 commits into from Jun 17, 2021

Conversation

akellbl4
Copy link
Contributor

@akellbl4 akellbl4 commented Jun 14, 2021

Fixes one of the items from #25854

Documentation / Examples

  • Make sure the linting passes
  • Add the StackBlitz button
  • Live demo

@ijjk ijjk added the examples Issue/PR related to examples label Jun 14, 2021
@akellbl4 akellbl4 requested a review from leerob June 14, 2021 18:39
@d3lm
Copy link
Contributor

d3lm commented Jun 17, 2021

I think the next config is not entirely correct. It throws

Error: `future.webpack5` in `next.config.js` has moved to the top level `webpack5` flag 
https://nextjs.org/docs/messages/future-webpack5-moved-to-webpack5

@akellbl4 akellbl4 force-pushed the examples/with-lingui-update branch from c190b2a to 918d841 Compare June 17, 2021 15:53
@akellbl4
Copy link
Contributor Author

@d3lm fixes. I removed the flag because webpack5 is enabled by default since v11.

@kodiakhq kodiakhq bot merged commit 9785ba8 into vercel:canary Jun 17, 2021
@d3lm d3lm mentioned this pull request Jun 19, 2021
20 tasks
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
Fixes one of the items from vercel#25854

## Documentation / Examples

- [x] Make sure the linting passes
- [x] Add the StackBlitz button
- [x] [Live demo](https://stackblitz.com/github/akellbl4/next.js/tree/examples/with-lingui-update/examples/with-lingui)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants