Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react@next and react@experimental tests #26088

Merged
merged 3 commits into from Jun 14, 2021

Conversation

devknoll
Copy link
Contributor

react-dom@next and react-dom@experimental now have a warning when using the deprecated ReactDOM.render(...) method, so we should make sure to ignore those in tests.

Additionally, we should run the react@next tests with the new createRoot API. We still need both tests though, because some features are/will only be available on the experimental channel initially.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@devknoll devknoll marked this pull request as ready for review June 14, 2021 19:04
@ijjk
Copy link
Member

ijjk commented Jun 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
buildDuration 14.5s 15s ⚠️ +513ms
buildDurationCached 3.5s 3.5s -68ms
nodeModulesSize 46.5 MB 46.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
/ failed reqs 0 0
/ total time (seconds) 2.79 2.781 -0.01
/ avg req/sec 896.17 899.12 +2.95
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.711 1.754 ⚠️ +0.04
/error-in-render avg req/sec 1461.23 1425.49 ⚠️ -35.74
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.17 kB 3.17 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.41 kB 8.41 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
_buildManifest.js gzip 391 B 391 B
Overall change 391 B 391 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Serverless Mode
General
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
buildDuration 16.7s 16.8s ⚠️ +110ms
buildDurationCached 4.7s 4.7s -9ms
nodeModulesSize 46.5 MB 46.5 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.17 kB 3.17 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.41 kB 8.41 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
_buildManifest.js gzip 391 B 391 B
Overall change 391 B 391 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
_error.js 16.9 kB 16.9 kB
404.html 1.98 kB 1.98 kB
500.html 1.96 kB 1.96 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.17 kB 1.17 kB
css.html 1.35 kB 1.35 kB
hooks.html 1.23 kB 1.23 kB
index.js 17.2 kB 17.2 kB
link.js 17.4 kB 17.4 kB ⚠️ +2 B
routerDirect.js 17.4 kB 17.4 kB
withRouter.js 17.4 kB 17.4 kB
Overall change 105 kB 105 kB ⚠️ +2 B

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
buildDuration 12.8s 13s ⚠️ +191ms
buildDurationCached 5.3s 5.2s -54ms
nodeModulesSize 46.5 MB 46.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
/ failed reqs 0 0
/ total time (seconds) 2.835 2.767 -0.07
/ avg req/sec 881.71 903.56 +21.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.724 1.721 0
/error-in-render avg req/sec 1450.14 1452.82 +2.68
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.99 kB 7.99 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 61.1 kB 61.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
_app-HASH.js gzip 1.07 kB 1.07 kB
_error-HASH.js gzip 3.84 kB 3.84 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.63 kB 1.63 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.27 kB 9.27 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js fix-next-experimental-tests Change
index.html gzip 568 B 568 B
link.html gzip 582 B 582 B
withRouter.html gzip 561 B 561 B
Overall change 1.71 kB 1.71 kB
Commit: bcba2fe

@ijjk ijjk merged commit 1f09a78 into vercel:canary Jun 14, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants