Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint version check for older versions #26212

Merged
merged 3 commits into from Jun 16, 2021
Merged

Fix eslint version check for older versions #26212

merged 3 commits into from Jun 16, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 16, 2021

This ensures we don't fail to access the version on older versions of eslint and adds a test case to ensure this is working as expected.

Fixes: #26126

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Jun 16, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
buildDuration 11s 11s -82ms
buildDurationCached 2.7s 2.7s -16ms
nodeModulesSize 46.4 MB 46.4 MB ⚠️ +32 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.979 2.019 ⚠️ +0.04
/ avg req/sec 1263.52 1238.42 ⚠️ -25.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.109 1.127 ⚠️ +0.02
/error-in-render avg req/sec 2253.94 2217.55 ⚠️ -36.39
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 329 B 329 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
_buildManifest.js gzip 391 B 391 B ✓
Overall change 391 B 391 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
index.html gzip 523 B 523 B ✓
link.html gzip 535 B 535 B ✓
withRouter.html gzip 514 B 514 B ✓
Overall change 1.57 kB 1.57 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
buildDuration 12.6s 12.5s -147ms
buildDurationCached 3.6s 3.6s -8ms
nodeModulesSize 46.4 MB 46.4 MB ⚠️ +32 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 329 B 329 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
_buildManifest.js gzip 391 B 391 B ✓
Overall change 391 B 391 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
_error.js 16.9 kB 16.9 kB -2 B
404.html 1.98 kB 1.98 kB ✓
500.html 1.96 kB 1.96 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.17 kB 1.17 kB ✓
css.html 1.35 kB 1.35 kB ✓
hooks.html 1.23 kB 1.23 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.5 kB 17.5 kB ✓
routerDirect.js 17.3 kB 17.3 kB ⚠️ +2 B
withRouter.js 17.3 kB 17.3 kB -2 B
Overall change 105 kB 105 kB -2 B
Webpack 4 Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
buildDuration 9.8s 9.8s -62ms
buildDurationCached 4s 3.9s -86ms
nodeModulesSize 46.4 MB 46.4 MB ⚠️ +32 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.027 1.969 -0.06
/ avg req/sec 1233.15 1269.92 +36.77
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.097 1.114 ⚠️ +0.02
/error-in-render avg req/sec 2278.03 2244.58 ⚠️ -33.45
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 41.8 kB 41.8 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 63.9 kB 63.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.84 kB 3.84 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 333 B 333 B ✓
hooks-HASH.js gzip 910 B 910 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 295 B 295 B ✓
withRouter-HASH.js gzip 292 B 292 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.28 kB 9.28 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/eslint-version-check Change
index.html gzip 568 B 568 B ✓
link.html gzip 579 B 579 B ✓
withRouter.html gzip 559 B 559 B ✓
Overall change 1.71 kB 1.71 kB ✓
Commit: 0a2921c

@ijjk ijjk merged commit 8610ba4 into vercel:canary Jun 16, 2021
@ijjk ijjk deleted the fix/eslint-version-check branch June 16, 2021 19:16
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 23, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
@ijjk
Fix eslint version check for older versions (vercel#26212)
0466a12
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

next lint fails when ESLint is not installed
2 participants
@ijjk @timneutkens