Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend disclaimer for dynamic image imports #26241

Merged
merged 7 commits into from Jun 18, 2021
Merged

Extend disclaimer for dynamic image imports #26241

merged 7 commits into from Jun 18, 2021

Conversation

joe-bell
Copy link
Contributor

@joe-bell joe-bell commented Jun 17, 2021 •
edited

Based on earlier discussions with @styfle

Extends documentation to include "remote" images until such a feature is added (#26208, #26168)

Includes external example for retrieving Image props for dynamic and remote in the meantime via plaiceholder

Full disclosure: I built plaiceholder so I'm aware of the bias here. My hope with this PR is that offer solutions could add themselves to the docs too; as I believe this will be a fairly common use-case for people building pages from a CMS or content API. Hopefully this will lead to less issues/questions being raised around the topic

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@joe-bell joe-bell marked this pull request as ready for review June 17, 2021 06:19
styfle
styfle previously approved these changes Jun 17, 2021
View reviewed changes
@styfle styfle requested a review from timneutkens June 18, 2021 13:46
@timneutkens timneutkens merged commit 98acfaf into vercel:canary Jun 18, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 23, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
@joe-bell @styfle @timneutkens
Extend disclaimer for dynamic image imports (vercel#26241)
4e75cda 
* docs: extend disclaimer for dynamic image imports

* docs: extend guidance on blurDataURL

* Update docs/api-reference/next/image.md

Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
@joe-bell joe-bell deleted the patch-1 branch June 26, 2021 15:31
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joe-bell @styfle @timneutkens @ijjk