Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest TypeScript version and de-dupe versions #26285

Merged
merged 2 commits into from Jun 17, 2021
Merged

Update to latest TypeScript version and de-dupe versions #26285

merged 2 commits into from Jun 17, 2021
+27 −39

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 17, 2021

This updates to the latest TypeScript version and de-dupes the version used between the monorepo for testing and the version used in packages/next.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: next labels Jun 17, 2021
styfle
styfle previously approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Jun 17, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/typescript Change
buildDuration 15.1s 15s -99ms
buildDurationCached 3.6s 3.6s ⚠️ +18ms
nodeModulesSize 46.4 MB 46.4 MB -961 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/typescript Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.792 2.781 -0.01
/ avg req/sec 895.4 898.86 +3.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.742 1.762 ⚠️ +0.02
/error-in-render avg req/sec 1435.07 1418.57 ⚠️ -16.5
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/typescript Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/typescript Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/typescript Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 329 B 329 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/typescript Change
_buildManifest.js gzip 391 B 391 B ✓
Overall change 391 B 391 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/typescript Change
index.html gzip 524 B 524 B ✓
link.html gzip 536 B 536 B ✓
withRouter.html gzip 516 B 516 B ✓
Overall change 1.58 kB 1.58 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/typescript Change
buildDuration 17s 17.1s ⚠️ +111ms
buildDurationCached 4.8s 4.8s -28ms
nodeModulesSize 46.4 MB 46.4 MB -961 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/typescript Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/typescript Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/typescript Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 329 B 329 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/typescript Change
_buildManifest.js gzip 391 B 391 B ✓
Overall change 391 B 391 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js update/typescript Change
_error.js 16.9 kB 16.9 kB ✓
404.html 1.98 kB 1.98 kB ✓
500.html 1.96 kB 1.96 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.17 kB 1.17 kB ✓
css.html 1.35 kB 1.35 kB ✓
hooks.html 1.23 kB 1.23 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.5 kB 17.5 kB ✓
routerDirect.js 17.3 kB 17.3 kB ✓
withRouter.js 17.3 kB 17.3 kB ✓
Overall change 105 kB 105 kB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/typescript Change
buildDuration 13.3s 13.4s ⚠️ +80ms
buildDurationCached 5.4s 5.3s -157ms
nodeModulesSize 46.4 MB 46.4 MB -961 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/typescript Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.835 2.814 -0.02
/ avg req/sec 881.86 888.53 +6.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.732 1.699 -0.03
/error-in-render avg req/sec 1443.58 1471.83 +28.25
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/typescript Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 41.8 kB 41.8 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 63.8 kB 63.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/typescript Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/typescript Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.84 kB 3.84 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 333 B 333 B ✓
hooks-HASH.js gzip 910 B 910 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 295 B 295 B ✓
withRouter-HASH.js gzip 292 B 292 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.28 kB 9.28 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/typescript Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/typescript Change
index.html gzip 567 B 567 B ✓
link.html gzip 579 B 579 B ✓
withRouter.html gzip 561 B 561 B ✓
Overall change 1.71 kB 1.71 kB ✓
Commit: 1ccecfc

@ijjk ijjk merged commit 76f0b35 into vercel:canary Jun 17, 2021
@ijjk ijjk deleted the update/typescript branch June 17, 2021 22:43
@rokinsky

This comment has been minimized.

Sign in to view
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 23, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
@ijjk
Update to latest TypeScript version and de-dupe versions (vercel#26285)
e53839c 
* Update to latest TypeScript version and de-dupe versions

* Update version test
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @rokinsky @styfle