Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for startLatency in fast refresh #26417

Merged
merged 1 commit into from Jun 21, 2021
Merged

Add check for startLatency in fast refresh #26417

merged 1 commit into from Jun 21, 2021

Conversation

timneutkens
Copy link
Member

Fixes the NaN message in the console. I couldn't reproduce this but got 2 separate reports, if someone ran into this please provide a reproduction so that a test can be added.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Jun 21, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
buildDuration 11.5s 11.3s -161ms
buildDurationCached 2.8s 2.7s -95ms
nodeModulesSize 49.2 MB 49.2 MB ⚠️ +85 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.032 2.067 ⚠️ +0.04
/ avg req/sec 1230.4 1209.63 ⚠️ -20.77
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.159 1.152 -0.01
/error-in-render avg req/sec 2156.32 2170.54 +14.22
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 810 B 810 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 330 B 330 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
index.html gzip 522 B 522 B ✓
link.html gzip 533 B 533 B ✓
withRouter.html gzip 517 B 517 B ✓
Overall change 1.57 kB 1.57 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
buildDuration 12.9s 13s ⚠️ +72ms
buildDurationCached 3.8s 3.8s -25ms
nodeModulesSize 49.2 MB 49.2 MB ⚠️ +85 B
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 810 B 810 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 330 B 330 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
_error.js 16.9 kB 16.9 kB ✓
404.html 1.98 kB 1.98 kB ✓
500.html 1.96 kB 1.96 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.17 kB 1.17 kB ✓
css.html 1.35 kB 1.35 kB ✓
hooks.html 1.23 kB 1.23 kB ✓
index.js 17.2 kB 17.2 kB ⚠️ +2 B
link.js 17.5 kB 17.5 kB ✓
routerDirect.js 17.3 kB 17.3 kB ✓
withRouter.js 17.3 kB 17.3 kB ✓
Overall change 105 kB 105 kB ⚠️ +2 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
buildDuration 10.1s 10.2s ⚠️ +112ms
buildDurationCached 4.2s 4.1s -66ms
nodeModulesSize 49.2 MB 49.2 MB ⚠️ +85 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.029 2.058 ⚠️ +0.03
/ avg req/sec 1232.38 1215.02 ⚠️ -17.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.127 1.144 ⚠️ +0.02
/error-in-render avg req/sec 2218.4 2184.38 ⚠️ -34.02
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 41.8 kB 41.8 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 757 B 757 B ✓
Overall change 63.8 kB 63.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.84 kB 3.84 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 333 B 333 B ✓
hooks-HASH.js gzip 910 B 910 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 295 B 295 B ✓
withRouter-HASH.js gzip 292 B 292 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.28 kB 9.28 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/nan-fast-refresh-done Change
index.html gzip 568 B 568 B ✓
link.html gzip 581 B 581 B ✓
withRouter.html gzip 560 B 560 B ✓
Overall change 1.71 kB 1.71 kB ✓
Commit: 000a165

@timneutkens timneutkens merged commit 4d13d67 into canary Jun 21, 2021
@timneutkens timneutkens deleted the fix/nan-fast-refresh-done branch June 21, 2021 14:28
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 23, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
@timneutkens
Add check for startLatency in fast refresh (vercel#26417)
32f78b9
bordeo pushed a commit to bordeo/next.js that referenced this pull request Jul 12, 2021
Merge tag 'v11.0.1' into feat/add-pagesPaths-config-options
8f0bca2 
v11.0.1

* tag 'v11.0.1': (374 commits)
  v11.0.1
  v11.0.1-canary.8
  Ensure image-types file is included (vercel#26495)
  Strongly type `Router.events.on` and `Router.events.off` (vercel#26456)
  v11.0.1-canary.7
  Update i18n fields in docs (vercel#26492)
  Update to only add image import types when enabled (vercel#26485)
  Fix domain locales not available on client (vercel#26083)
  chore: Add Alex to lint documentation (vercel#26354)
  fix: ignore invalid accept-language header (vercel#26476)
  Add module.exports to security headers documentation (vercel#26466)
  (examples/with-webassembly) fixed for webpack 5 (vercel#26440)
  Add check for startLatency in fast refresh (vercel#26417)
  v11.0.1-canary.6
  docs(router.md) Add note about page state and navigation (vercel#26320)
  Remove period for ESLint `passHref` docs link. (vercel#26402)
  Update with-eslint example. (vercel#25817)
  Docs: Add Prettier section on ESLint page (vercel#26347)
  add missing closing bracket (vercel#26375)
  Improve the `next/script` documentation. (vercel#26325)
  ...
@snyk-bot snyk-bot mentioned this pull request Jul 30, 2021
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timneutkens @ijjk