Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Added with-couchbase example #27184

Merged
merged 25 commits into from Aug 24, 2021
Merged

[examples] Added with-couchbase example #27184

merged 25 commits into from Aug 24, 2021

Conversation

ejscribner
Copy link
Contributor

@ejscribner ejscribner commented Jul 15, 2021

This adds a simple with-couchbase example app complete with a check for successful connection (in index.js).

Note: To check the connection, this application runs a simple KV GET operation with a key that does not exist and expects a response of document not found. Any other response indicates a failure to connect.

Thank you!

@ijjk ijjk added the examples Issue/PR related to examples label Jul 15, 2021
@ejscribner ejscribner changed the title Add with-couchbase example added with-couchbase example Jul 20, 2021
@styfle styfle removed their request for review August 10, 2021 17:42
@ejscribner
Copy link
Contributor Author

@leerob Any chance we could get a re-review on this? Updated a few things and simplified the index.js page to make it easier for first time users.

examples/with-couchbase/package.json Outdated Show resolved Hide resolved
examples/with-couchbase/pages/index.js Outdated Show resolved Hide resolved
examples/with-couchbase/util/couchbase.js Outdated Show resolved Hide resolved
@ejscribner
Copy link
Contributor Author

ejscribner commented Aug 24, 2021

(1) Updated to use ESM to import couchbase, (2) added "private": true, to package.json, and (3) upgraded to use CSS modules. Thanks for the feedback @leerob !!

@ejscribner ejscribner requested a review from leerob August 24, 2021 01:34
examples/with-couchbase/README.md Outdated Show resolved Hide resolved

Set each variable on `.env.local`:

- `COUCHBASE_USERNAME` - The username of an authorized user on your Couchbase instance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: It'd be great if there was an integration that took care of this for you 😄

https://vercel.com/integrations#databases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add this ASAP!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leerob leerob changed the title added with-couchbase example [examples] Added with-couchbase example Aug 24, 2021
@kodiakhq kodiakhq bot merged commit 6072afc into vercel:canary Aug 24, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants