Add missing fields to NextConfig type
#27974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprobst
requested review from
huozhi,
ijjk,
padmaia,
shuding,
styfle and
timneutkens
as code owners
This comment has been minimized.
This comment has been minimized.
timneutkens
reviewed
Aug 12, 2021
| @@ -1,6 +1,7 @@ | |||
| import os from 'os' | |||
| import { Header, Redirect, Rewrite } from '../lib/load-custom-routes' | |||
| import { ImageConfig, imageConfigDefault } from './image-config' | |||
| import type webpack from 'webpack' | |||
There was a problem hiding this comment.
This type will be incorrect, config should likely be unknown or any in this particular case as webpack is compiled and it can be either webpack 4 or 5, the types referred here are webpack 4.
There was a problem hiding this comment.
ah, i had assumed it would pick up these types. i'll change to any then.
This comment has been minimized.
This comment has been minimized.
styfle
approved these changes
Aug 12, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ijjk
approved these changes
Aug 12, 2021
Stats from current PRDefault Build (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| buildDuration | 12.3s | 12.6s | |
| buildDurationCached | 3s | 2.8s | -218ms |
| nodeModulesSize | 49.1 MB | 49.1 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.225 | 2.277 | |
| / avg req/sec | 1123.61 | 1097.92 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.277 | 1.265 | -0.01 |
| /error-in-render avg req/sec | 1958.19 | 1977.01 | +18.82 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| 745.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 23.1 kB | 23.1 kB | ✓ |
| webpack-HASH.js gzip | 1.5 kB | 1.5 kB | ✓ |
| Overall change | 67 kB | 67 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 980 B | 980 B | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 329 B | 329 B | ✓ |
| dynamic-HASH.js gzip | 2.52 kB | 2.52 kB | ✓ |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 904 B | 904 B | ✓ |
| image-HASH.js gzip | 4.13 kB | 4.13 kB | ✓ |
| index-HASH.js gzip | 261 B | 261 B | ✓ |
| link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
| routerDirect..HASH.js gzip | 319 B | 319 B | ✓ |
| script-HASH.js gzip | 387 B | 387 B | ✓ |
| withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 12.8 kB | 12.8 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 491 B | 491 B | ✓ |
| Overall change | 491 B | 491 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| index.html gzip | 532 B | 532 B | ✓ |
| link.html gzip | 543 B | 543 B | ✓ |
| withRouter.html gzip | 524 B | 524 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
Webpack 4 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| buildDuration | 10s | 10s | |
| buildDurationCached | 4.3s | 3.9s | -425ms |
| nodeModulesSize | 49.1 MB | 49.1 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.298 | 2.143 | -0.16 |
| / avg req/sec | 1087.83 | 1166.82 | +78.99 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.234 | 1.251 | |
| /error-in-render avg req/sec | 2026.72 | 1998.39 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| 17.HASH.js gzip | 185 B | 185 B | ✓ |
| 677f882d2ed8..HASH.js gzip | 14 kB | 14 kB | ✓ |
| framework.HASH.js gzip | 41.9 kB | 41.9 kB | ✓ |
| main-HASH.js gzip | 10.6 kB | 10.6 kB | ✓ |
| webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
| Overall change | 67.8 kB | 67.8 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 965 B | 965 B | ✓ |
| _error-HASH.js gzip | 3.71 kB | 3.71 kB | ✓ |
| amp-HASH.js gzip | 552 B | 552 B | ✓ |
| css-HASH.js gzip | 333 B | 333 B | ✓ |
| dynamic-HASH.js gzip | 2.71 kB | 2.71 kB | ✓ |
| head-HASH.js gzip | 2.97 kB | 2.97 kB | ✓ |
| hooks-HASH.js gzip | 911 B | 911 B | ✓ |
| index-HASH.js gzip | 231 B | 231 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 298 B | 298 B | ✓ |
| script-HASH.js gzip | 2.95 kB | 2.95 kB | ✓ |
| withRouter-HASH.js gzip | 294 B | 294 B | ✓ |
| e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 17.7 kB | 17.7 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 498 B | 498 B | ✓ |
| Overall change | 498 B | 498 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | stefanprobst/next.js chore/next-config-type | Change | |
|---|---|---|---|
| index.html gzip | 576 B | 576 B | ✓ |
| link.html gzip | 589 B | 589 B | ✓ |
| withRouter.html gzip | 569 B | 569 B | ✓ |
| Overall change | 1.73 kB | 1.73 kB | ✓ |
10 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 24, 2021
This is similar to #27126 , #27446 and #27974 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes
This was referenced Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
poweredByHeaderandwebpackfields to the publicNextConfigtype.Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples