Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Execute development-logs tests. #27996

Merged
merged 2 commits into from Aug 12, 2021

Conversation

andersonleite
Copy link
Contributor

@andersonleite andersonleite commented Aug 12, 2021

The tests to assert development logs when using Link are being ignored.
After adding them to integration/basic they execute correctly as can be seen in the log below:

Development Logs
      ✓ should warn when prefetch is true (1345 ms)
      ✓ should not warn when prefetch is false (879 ms)
      ✓ should not warn when prefetch is not specified (834 ms)

Test Suites: 1 skipped, 1 passed, 1 of 2 total
Tests:       88 skipped, 3 passed, 91 total

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@andersonleite andersonleite changed the title Tests: Execute development logs tests. Tests: Execute development-logs tests. Aug 12, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 12, 2021

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
buildDuration 16s 16.3s ⚠️ +305ms
buildDurationCached 3.6s 3.6s ⚠️ +1ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +3 B
Page Load Tests Overall increase ✓
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
/ failed reqs 0 0
/ total time (seconds) 3.104 3.066 -0.04
/ avg req/sec 805.52 815.34 +9.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.888 1.899 ⚠️ +0.01
/error-in-render avg req/sec 1323.89 1316.38 ⚠️ -7.51
Client Bundles (main, webpack, commons)
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
buildDuration 13.5s 13.6s ⚠️ +95ms
buildDurationCached 5.4s 5.1s -273ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +3 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
/ failed reqs 0 0
/ total time (seconds) 3.078 3.082 0
/ avg req/sec 812.16 811.03 ⚠️ -1.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.886 1.931 ⚠️ +0.05
/error-in-render avg req/sec 1325.38 1294.5 ⚠️ -30.88
Client Bundles (main, webpack, commons)
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary andersonleite/next.js feat-development-logs-test Change
index.html gzip 577 B 577 B
link.html gzip 589 B 589 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: 746a058

@timneutkens timneutkens merged commit 27ccd3c into vercel:canary Aug 12, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants