Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore to examples that lack them #28003

Merged
merged 7 commits into from Aug 12, 2021
Merged

Conversation

oBusk
Copy link
Contributor

@oBusk oBusk commented Aug 12, 2021

So doing #27983 I found that there were multiple examples that doesn't have any .gitignore at all.

While I can see that create-next-app will copy the default .gitignore if there is none, but I felt like it would be nice if the example has it if you happen to download the folder instead of use create-next-app.

I used the check-examples script to add the gitignores, however I noticed that there is an example that is not actually a package (custom-server) so I changed the script to only do it in actual examples.

@ijjk ijjk added the examples Issue/PR related to examples label Aug 12, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

ijjk
ijjk previously approved these changes Aug 12, 2021
styfle
styfle previously approved these changes Aug 12, 2021
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oBusk oBusk dismissed stale reviews from styfle and ijjk via 7aa78e6 August 12, 2021 18:50
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 12, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary oBusk/next.js add-gitignores Change
buildDuration 16.3s 16s -272ms
buildDurationCached 3.7s 3.8s ⚠️ +58ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary oBusk/next.js add-gitignores Change
/ failed reqs 0 0
/ total time (seconds) 2.992 2.971 -0.02
/ avg req/sec 835.47 841.5 +6.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.933 1.866 -0.07
/error-in-render avg req/sec 1293.48 1340.03 +46.55
Client Bundles (main, webpack, commons)
vercel/next.js canary oBusk/next.js add-gitignores Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary oBusk/next.js add-gitignores Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary oBusk/next.js add-gitignores Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary oBusk/next.js add-gitignores Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary oBusk/next.js add-gitignores Change
index.html gzip 531 B 531 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary oBusk/next.js add-gitignores Change
buildDuration 12.9s 13.2s ⚠️ +319ms
buildDurationCached 5.2s 5.2s -29ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary oBusk/next.js add-gitignores Change
/ failed reqs 0 0
/ total time (seconds) 2.833 2.898 ⚠️ +0.06
/ avg req/sec 882.45 862.6 ⚠️ -19.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.846 1.793 -0.05
/error-in-render avg req/sec 1354.51 1394.27 +39.76
Client Bundles (main, webpack, commons)
vercel/next.js canary oBusk/next.js add-gitignores Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary oBusk/next.js add-gitignores Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary oBusk/next.js add-gitignores Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary oBusk/next.js add-gitignores Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary oBusk/next.js add-gitignores Change
index.html gzip 576 B 576 B
link.html gzip 590 B 590 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: 85497d2

@ijjk ijjk merged commit 6403a99 into vercel:canary Aug 12, 2021
@oBusk oBusk deleted the add-gitignores branch August 12, 2021 21:51
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants