Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all example packages has private: true #28008

Merged
merged 6 commits into from Aug 12, 2021

Conversation

oBusk
Copy link
Contributor

@oBusk oBusk commented Aug 12, 2021

Update the check-exampels.sh script to also ensure all examples has private: true (763d997)

Update exampels (1) that did not have private: true (bcdc4a3)

@ijjk ijjk added the examples Issue/PR related to examples label Aug 12, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk

This comment has been minimized.

@@ -3,7 +3,7 @@
for folder in examples/* ; do
cp -n packages/create-next-app/templates/default/gitignore $folder/.gitignore;
if [ -f "$folder/package.json" ]; then
cat $folder/package.json | jq '.license = "MIT"' | sponge $folder/package.json
cat $folder/package.json | jq '.license = "MIT" | .private = true' | sponge $folder/package.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like we are running this in CI currently, can we add this to the lint job here

- run: ./scripts/check-manifests.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijjk I was actually creating a separate PR for that! (#28009) Just so it'd be a bit clearer what each PR does 😄 Also, the job would fail until the other PRs that does various fixes to examples should probably be merged first so that everything is fine once the CI starts checking it

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 12, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary oBusk/next.js examples-package-private Change
buildDuration 15.9s 15.7s -170ms
buildDurationCached 3.5s 3.5s -3ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary oBusk/next.js examples-package-private Change
/ failed reqs 0 0
/ total time (seconds) 2.894 2.939 ⚠️ +0.04
/ avg req/sec 863.95 850.62 ⚠️ -13.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.813 1.867 ⚠️ +0.05
/error-in-render avg req/sec 1378.58 1338.88 ⚠️ -39.7
Client Bundles (main, webpack, commons)
vercel/next.js canary oBusk/next.js examples-package-private Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary oBusk/next.js examples-package-private Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary oBusk/next.js examples-package-private Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary oBusk/next.js examples-package-private Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary oBusk/next.js examples-package-private Change
index.html gzip 532 B 532 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary oBusk/next.js examples-package-private Change
buildDuration 12.8s 12.8s -18ms
buildDurationCached 5s 5s -29ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary oBusk/next.js examples-package-private Change
/ failed reqs 0 0
/ total time (seconds) 2.894 2.937 ⚠️ +0.04
/ avg req/sec 863.93 851.2 ⚠️ -12.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.871 1.896 ⚠️ +0.02
/error-in-render avg req/sec 1336.33 1318.85 ⚠️ -17.48
Client Bundles (main, webpack, commons)
vercel/next.js canary oBusk/next.js examples-package-private Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary oBusk/next.js examples-package-private Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary oBusk/next.js examples-package-private Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary oBusk/next.js examples-package-private Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary oBusk/next.js examples-package-private Change
index.html gzip 576 B 576 B
link.html gzip 589 B 589 B
withRouter.html gzip 569 B 569 B
Overall change 1.73 kB 1.73 kB
Commit: 09007be

@kodiakhq kodiakhq bot merged commit 69d6001 into vercel:canary Aug 12, 2021
@oBusk oBusk deleted the examples-package-private branch August 12, 2021 18:48
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants