Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish native script #28037

Merged
merged 2 commits into from Aug 12, 2021
Merged

Fix publish native script #28037

merged 2 commits into from Aug 12, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Aug 12, 2021

I've been writing too much rust code...

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Aug 12, 2021
@ijjk
Copy link
Member

ijjk commented Aug 12, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary padmaia/next.js fix/publish-native Change
buildDuration 12.5s 12.6s ⚠️ +117ms
buildDurationCached 2.9s 2.9s -30ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js fix/publish-native Change
/ failed reqs 0 0
/ total time (seconds) 2.212 2.3 ⚠️ +0.09
/ avg req/sec 1130.17 1086.9 ⚠️ -43.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.269 1.229 -0.04
/error-in-render avg req/sec 1969.99 2034.62 +64.63
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix/publish-native Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix/publish-native Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary padmaia/next.js fix/publish-native Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js fix/publish-native Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix/publish-native Change
index.html gzip 532 B 532 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary padmaia/next.js fix/publish-native Change
buildDuration 11.1s 10.9s -186ms
buildDurationCached 4.2s 4.1s -153ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js fix/publish-native Change
/ failed reqs 0 0
/ total time (seconds) 2.428 2.306 -0.12
/ avg req/sec 1029.54 1084.17 +54.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.358 1.266 -0.09
/error-in-render avg req/sec 1840.5 1974.01 +133.51
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix/publish-native Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix/publish-native Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary padmaia/next.js fix/publish-native Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js fix/publish-native Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix/publish-native Change
index.html gzip 576 B 576 B
link.html gzip 589 B 589 B
withRouter.html gzip 569 B 569 B
Overall change 1.73 kB 1.73 kB
Commit: 86f1d16

@padmaia padmaia merged commit f067897 into vercel:canary Aug 12, 2021
@padmaia padmaia deleted the fix/publish-native branch August 12, 2021 16:46
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants