Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip native ci steps for docs only changes #28101

Merged
merged 3 commits into from Aug 14, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 14, 2021

Follow-up to #28092 this adds skipping native build CI steps for docs only changes

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Aug 14, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review August 14, 2021 04:28
@ijjk

This comment has been minimized.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we skip at the job level instead of each step?

@ijjk
Copy link
Member Author

ijjk commented Aug 14, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
buildDuration 14s 13.9s -129ms
buildDurationCached 3.4s 3.4s -62ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
/ failed reqs 0 0
/ total time (seconds) 3.001 2.873 -0.13
/ avg req/sec 833.1 870.1 +37
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.768 1.796 ⚠️ +0.03
/error-in-render avg req/sec 1414.2 1392.03 ⚠️ -22.17
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.64 kB 2.64 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
buildDuration 11.2s 11.3s ⚠️ +91ms
buildDurationCached 4.6s 4.6s -9ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
/ failed reqs 0 0
/ total time (seconds) 2.874 2.845 -0.03
/ avg req/sec 869.98 878.7 +8.72
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.789 1.743 -0.05
/error-in-render avg req/sec 1397.69 1434.56 +36.87
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.83 kB 2.83 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.8 kB 17.8 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
_buildManifest.js gzip 497 B 497 B
Overall change 497 B 497 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js skip/docs-native-test Change
index.html gzip 585 B 585 B
link.html gzip 598 B 598 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB
Commit: 9727e6b

@ijjk ijjk merged commit c3dcc96 into vercel:canary Aug 14, 2021
@ijjk ijjk deleted the skip/docs-native-test branch August 14, 2021 14:28
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants