Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup for m1 build #28138

Merged
merged 3 commits into from Aug 15, 2021
Merged

Add setup for m1 build #28138

merged 3 commits into from Aug 15, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Aug 15, 2021

Fixes an issue with m1 builds, related swc PR here: https://github.com/swc-project/swc/pull/1939/files

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Aug 15, 2021
@ijjk

This comment has been minimized.

huozhi
huozhi previously approved these changes Aug 15, 2021
ijjk
ijjk previously approved these changes Aug 15, 2021
@padmaia padmaia dismissed stale reviews from ijjk and huozhi August 15, 2021 17:53

need to make one more change

@ijjk

This comment has been minimized.

@padmaia
Copy link
Member Author

padmaia commented Aug 15, 2021

@huozhi @ijjk I dismissed your approvals because I realized I need to add something to the cache key and the build was close to auto merging. It should be ready now.

@ijjk
Copy link
Member

ijjk commented Aug 15, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary padmaia/next.js fix-m1-native Change
buildDuration 16.7s 16.5s -257ms
buildDurationCached 4.1s 4s -94ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js fix-m1-native Change
/ failed reqs 0 0
/ total time (seconds) 3.24 3.379 ⚠️ +0.14
/ avg req/sec 771.62 739.91 ⚠️ -31.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.973 1.891 -0.08
/error-in-render avg req/sec 1267.38 1322.3 +54.92
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix-m1-native Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix-m1-native Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js fix-m1-native Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.64 kB 2.64 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js fix-m1-native Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix-m1-native Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary padmaia/next.js fix-m1-native Change
buildDuration 13.1s 13.1s -11ms
buildDurationCached 5.6s 5.4s -162ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js fix-m1-native Change
/ failed reqs 0 0
/ total time (seconds) 3.104 3.217 ⚠️ +0.11
/ avg req/sec 805.38 777.24 ⚠️ -28.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.997 1.973 -0.02
/error-in-render avg req/sec 1252.08 1267.34 +15.26
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix-m1-native Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix-m1-native Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js fix-m1-native Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.83 kB 2.83 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.8 kB 17.8 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js fix-m1-native Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix-m1-native Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB
Commit: 7cc8063

@ijjk
Copy link
Member

ijjk commented Aug 15, 2021

Failing test suites

Commit: 7cc8063

test/acceptance/ReactRefreshLogBox.dev.test.js

  • server-side only compilation errors

Expand output

● server-side only compilation errors

ScriptTimeoutError: script timeout
  (Session info: headless chrome=92.0.4515.131)

  72 |
  73 |             // Wait for application to re-hydrate:
> 74 |             await browser.executeAsyncScript(function () {
     |             ^
  75 |               var callback = arguments[arguments.length - 1]
  76 |               if (window.__NEXT_HYDRATED) {
  77 |                 callback()

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
      at runMicrotasks (<anonymous>)
  at Proxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.patch (acceptance/helpers.js:74:13)
  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:1432:3)

@padmaia padmaia merged commit 97f9b64 into vercel:canary Aug 15, 2021
@padmaia padmaia deleted the fix-m1-native branch September 15, 2021 17:06
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants