Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash of lint rule no-document-import-in-page #28148

Merged
merged 3 commits into from Aug 16, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Aug 16, 2021

Fixes #28030
Fixes #28169

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 16, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
buildDuration 10.8s 11s ⚠️ +232ms
buildDurationCached 2.8s 2.6s -148ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +2 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
/ failed reqs 0 0
/ total time (seconds) 2.222 2.123 -0.1
/ avg req/sec 1124.97 1177.48 +52.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.227 1.149 -0.08
/error-in-render avg req/sec 2036.77 2176.34 +139.57
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.64 kB 2.64 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
index.html gzip 540 B 540 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
buildDuration 8.6s 9.2s ⚠️ +566ms
buildDurationCached 3.8s 3.8s ⚠️ +48ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
/ failed reqs 0 0
/ total time (seconds) 2.082 2.237 ⚠️ +0.16
/ avg req/sec 1201.05 1117.75 ⚠️ -83.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.185 1.318 ⚠️ +0.13
/error-in-render avg req/sec 2109.64 1897.53 ⚠️ -212.11
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.83 kB 2.83 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.8 kB 17.8 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/lint-document-imports Change
index.html gzip 584 B 584 B
link.html gzip 596 B 596 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 0cca261

@kodiakhq kodiakhq bot merged commit 90eae2c into vercel:canary Aug 16, 2021
msrcodes added a commit to gdscports/admins-2021-boilerplate-next that referenced this pull request Aug 22, 2021
msrcodes added a commit to gdscports/admins-2021-boilerplate-next that referenced this pull request Aug 22, 2021
msrcodes added a commit to gdscports/admins-2021-boilerplate-next that referenced this pull request Aug 22, 2021
this will print an error until next.js 11.1.1 is released, per vercel/next.js#28148
@habovh
Copy link

habovh commented Dec 17, 2021

I only see the merge commit on canary branch, has this been part of an actual release?

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@huozhi huozhi deleted the fix/lint-document-imports branch February 3, 2022 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
4 participants