Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): fixes typo in basic integration test #28158

Merged
merged 1 commit into from Aug 16, 2021

Conversation

bmuenzenmeyer
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

While reading the code I noticed this typo.

@ijjk
Copy link
Member

ijjk commented Aug 16, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
buildDuration 11.6s 11.2s -328ms
buildDurationCached 2.9s 2.9s ⚠️ +7ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.187 2.279 ⚠️ +0.09
/ avg req/sec 1142.97 1097.19 ⚠️ -45.78
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.264 1.222 -0.04
/error-in-render avg req/sec 1977.09 2046.35 +69.26
Client Bundles (main, webpack, commons)
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.64 kB 2.64 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
index.html gzip 540 B 540 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
buildDuration 9s 9.1s ⚠️ +109ms
buildDurationCached 3.9s 4s ⚠️ +113ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.176 2.265 ⚠️ +0.09
/ avg req/sec 1149.05 1103.98 ⚠️ -45.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.262 1.305 ⚠️ +0.04
/error-in-render avg req/sec 1981.43 1915.06 ⚠️ -66.37
Client Bundles (main, webpack, commons)
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.83 kB 2.83 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.8 kB 17.8 kB
Client Build Manifests
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary bmuenzenmeyer/next.js patch-1 Change
index.html gzip 584 B 584 B
link.html gzip 596 B 596 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 7fb96e5

@kodiakhq kodiakhq bot merged commit 49c3e0a into vercel:canary Aug 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants