Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve jaeger traces #28168

Merged
merged 6 commits into from Aug 17, 2021
Merged

Improve jaeger traces #28168

merged 6 commits into from Aug 17, 2021

Conversation

timneutkens
Copy link
Member

  • Ensure reporter flushes all traces
  • Ensure tracing events are correctly collected in Jaeger
  • Add trace for webpack emit

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 16, 2021
styfle
styfle previously approved these changes Aug 16, 2021
View reviewed changes
@timneutkens
Merge branch 'canary' of github.com:vercel/next.js into add/jaeger-im…
3616da1 
…provements

# Conflicts:
#	packages/next/telemetry/trace/report/index.ts
#	packages/next/telemetry/trace/report/to-jaeger.ts
@ijjk

This comment has been minimized.

Sign in to view
@timneutkens @harshcut
Update packages/next/telemetry/trace/report/to-jaeger.ts
dbf27cd 
Co-authored-by: Harsh Karande <harshskarande@gmail.com>
@ijjk
Copy link
Member

ijjk commented Aug 17, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
buildDuration 13.6s 13.7s ⚠️ +51ms
buildDurationCached 3.5s 3.4s -111ms
nodeModulesSize 49.7 MB 49.7 MB -3.12 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.747 2.789 ⚠️ +0.04
/ avg req/sec 909.95 896.23 ⚠️ -13.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.632 1.683 ⚠️ +0.05
/error-in-render avg req/sec 1531.98 1485.7 ⚠️ -46.28
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
745.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 23.1 kB 23.1 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 67 kB 67 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
_app-HASH.js gzip 980 B 980 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.64 kB 2.64 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 904 B 904 B ✓
image-HASH.js gzip 4.13 kB 4.13 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 319 B 319 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 12.9 kB 12.9 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
_buildManifest.js gzip 491 B 491 B ✓
Overall change 491 B 491 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
index.html gzip 539 B 539 B ✓
link.html gzip 551 B 551 B ✓
withRouter.html gzip 530 B 530 B ✓
Overall change 1.62 kB 1.62 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
buildDuration 11s 11.2s ⚠️ +213ms
buildDurationCached 4.7s 4.6s -127ms
nodeModulesSize 49.7 MB 49.7 MB -3.12 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.612 2.767 ⚠️ +0.15
/ avg req/sec 957.21 903.61 ⚠️ -53.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.423 1.495 ⚠️ +0.07
/error-in-render avg req/sec 1756.83 1672.03 ⚠️ -84.8
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
16.HASH.js gzip 186 B 186 B ✓
677f882d2ed8..HASH.js gzip 14 kB 14 kB ✓
framework.HASH.js gzip 41.9 kB 41.9 kB ✓
main-HASH.js gzip 10.6 kB 10.6 kB ✓
webpack-HASH.js gzip 1.19 kB 1.19 kB ✓
Overall change 67.9 kB 67.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
_app-HASH.js gzip 965 B 965 B ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 552 B 552 B ✓
css-HASH.js gzip 333 B 333 B ✓
dynamic-HASH.js gzip 2.83 kB 2.83 kB ✓
head-HASH.js gzip 2.97 kB 2.97 kB ✓
hooks-HASH.js gzip 911 B 911 B ✓
index-HASH.js gzip 231 B 231 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 298 B 298 B ✓
script-HASH.js gzip 2.95 kB 2.95 kB ✓
withRouter-HASH.js gzip 294 B 294 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 17.8 kB 17.8 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
_buildManifest.js gzip 498 B 498 B ✓
Overall change 498 B 498 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/jaeger-improvements Change
index.html gzip 585 B 585 B ✓
link.html gzip 596 B 596 B ✓
withRouter.html gzip 578 B 578 B ✓
Overall change 1.76 kB 1.76 kB ✓
Commit: dbf27cd

@timneutkens timneutkens merged commit 2b7d461 into vercel:canary Aug 17, 2021
@timneutkens timneutkens deleted the add/jaeger-improvements branch August 17, 2021 07:18
This was referenced Sep 1, 2021
Closed
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshcut harshcut harshcut left review comments

@styfle styfle styfle left review comments

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timneutkens @ijjk @styfle @harshcut