Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint Plugin] Handles edge case for no-import-document-in-page rule #28261

Merged
merged 5 commits into from Aug 25, 2021
Merged

[ESLint Plugin] Handles edge case for no-import-document-in-page rule #28261

merged 5 commits into from Aug 25, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

This PR handles the edge case for the no-import-document-in-page ESLint plugin rule for instances where the file path has the word pages elsewhere than the specific Next.js pages/

Fixes #28200

@ijjk ijjk added the created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora label Aug 18, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 25, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
buildDuration 17s 17s -41ms
buildDurationCached 3.7s 3.8s ⚠️ +117ms
nodeModulesSize 61.7 MB 61.7 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
/ failed reqs 0 0
/ total time (seconds) 3.084 3.081 0
/ avg req/sec 810.59 811.41 +0.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.879 1.932 ⚠️ +0.05
/error-in-render avg req/sec 1330.24 1293.83 ⚠️ -36.41
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
index.html gzip 539 B 539 B
link.html gzip 553 B 553 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
buildDuration 14s 14s ⚠️ +6ms
buildDurationCached 5.9s 5.9s -41ms
nodeModulesSize 61.7 MB 61.7 MB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
/ failed reqs 0 0
/ total time (seconds) 3.208 3.167 -0.04
/ avg req/sec 779.36 789.3 +9.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.934 1.918 -0.02
/error-in-render avg req/sec 1292.61 1303.49 +10.88
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js bug/#28200 Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 319fa27

This was referenced Sep 3, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive error from no-document-import-in-page rule
3 participants