Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all packages are packed while tracing #28263

Merged
merged 3 commits into from Aug 18, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 18, 2021

This ensures we pack all packages with yarn when tracing next-server so that we can create a fresh next install even when the version has been bumped and it isn't available on npm yet. This matches how we install versions not available on npm locally while generating the PR/release stats.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Aug 18, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Aug 18, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
buildDuration 14.8s 15.2s ⚠️ +356ms
buildDurationCached 3.6s 3.8s ⚠️ +196ms
nodeModulesSize 61.4 MB 61.4 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
/ failed reqs 0 0
/ total time (seconds) 2.782 2.846 ⚠️ +0.06
/ avg req/sec 898.79 878.34 ⚠️ -20.45
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.757 1.834 ⚠️ +0.08
/error-in-render avg req/sec 1422.91 1363.42 ⚠️ -59.49
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.2 kB 23.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
index.html gzip 539 B 539 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
buildDuration 12.4s 12s -439ms
buildDurationCached 5.1s 5.1s ⚠️ +63ms
nodeModulesSize 61.4 MB 61.4 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
/ failed reqs 0 0
/ total time (seconds) 2.888 2.778 -0.11
/ avg req/sec 865.72 899.91 +34.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.75 1.709 -0.04
/error-in-render avg req/sec 1428.26 1462.51 +34.25
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.98 kB 2.98 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/trace-during-publish Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 1d1b120

@ijjk ijjk marked this pull request as ready for review August 18, 2021 20:44
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test?

fs.unlinkSync(packagePath)
})
// remove changes to package.json files from packing
await execa('git', ['checkout', '.'], {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be package.json instead of .?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that remove changes to all package.json files in the tree or just the top-level one? This currently modifies all packages/*/package.json files to ensure we link to the packed versions correctly and then we want to undo those changes here after we're done installing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. then it could be git checkout packages/*/package.json but I suppose theres no harm in checking out everything.

Also if there are additional files created you could do git clean -fd

@ijjk ijjk merged commit f2fa4f3 into vercel:canary Aug 18, 2021
@ijjk ijjk deleted the fix/trace-during-publish branch August 18, 2021 21:30
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants