Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polling env var for tests in CI #28264

Merged
merged 6 commits into from Aug 18, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 18, 2021

This updates to set the watchpack polling env variable when running tests in CI since it is used instead of chokidar with webpack 5

This also applies the suggestion from actions/runner-images#1187 to disable tcp/udp offloading to hopefully help with the network flakiness we've seen

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Aug 18, 2021
@ijjk ijjk marked this pull request as ready for review August 18, 2021 17:55
@ijjk ijjk requested a review from sokra August 18, 2021 17:56
styfle
styfle previously approved these changes Aug 18, 2021
@ijjk

This comment has been minimized.

styfle
styfle previously approved these changes Aug 18, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

This reverts commit 281875d.
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Aug 18, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/test-retry Change
buildDuration 14.8s 14.9s ⚠️ +77ms
buildDurationCached 3.8s 3.7s -11ms
nodeModulesSize 61.4 MB 61.4 MB -2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/test-retry Change
/ failed reqs 0 0
/ total time (seconds) 2.606 2.7 ⚠️ +0.09
/ avg req/sec 959.16 925.87 ⚠️ -33.29
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.464 1.506 ⚠️ +0.04
/error-in-render avg req/sec 1707.88 1660.36 ⚠️ -47.52
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/test-retry Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.2 kB 23.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/test-retry Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/test-retry Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/test-retry Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/test-retry Change
index.html gzip 539 B 539 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/test-retry Change
buildDuration 12.4s 12.4s ⚠️ +5ms
buildDurationCached 5.1s 5.1s -55ms
nodeModulesSize 61.4 MB 61.4 MB -2 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/test-retry Change
/ failed reqs 0 0
/ total time (seconds) 2.656 2.69 ⚠️ +0.03
/ avg req/sec 941.15 929.44 ⚠️ -11.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.466 1.453 -0.01
/error-in-render avg req/sec 1705.08 1720.53 +15.45
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/test-retry Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/test-retry Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/test-retry Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.98 kB 2.98 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/test-retry Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/test-retry Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: c11da77

@ijjk ijjk requested a review from styfle August 18, 2021 20:12
@ijjk ijjk merged commit a342fba into vercel:canary Aug 18, 2021
@ijjk ijjk deleted the update/test-retry branch August 18, 2021 20:29
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever this kind of magic commands are for...

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants