Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use temp repo copy while linking packages #28301

Merged
merged 3 commits into from Aug 19, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 19, 2021

This fixes the packages containing incorrect content after linking during publish potentially from a race condition with lerna publishing by using a separate copy of the repo to link against

This fixes the latest canary failing to install from incorrect package references:

screenshot Screen Shot 2021-08-19 at 11 53 05

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Aug 19, 2021
Co-authored-by: Jiachi Liu <inbox@huozhi.im>
@ijjk ijjk requested a review from huozhi August 19, 2021 17:05
@ijjk ijjk merged commit f525ab6 into vercel:canary Aug 19, 2021
@ijjk ijjk deleted the fix/trace-packages branch August 19, 2021 17:23
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants