Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-react-intl example #28336

Merged
merged 3 commits into from Sep 20, 2021
Merged

Update with-react-intl example #28336

merged 3 commits into from Sep 20, 2021

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Aug 20, 2021 •
edited

This PR implements Internationalized Routing using formatjs / react-intl.

Changelog

  • Updated formatjs to latest version
  • Remove deprecated babel-react-intl-plugin in favor of babel-formatjs-plugin
  • Remove server in favour of Internationalized Routing
  • Added linter with formatjs rules
  • Refactored JSX
  • Added missing types
  • Auto run formtjs script via before hooks
  • Adjusted readme docs
  • Added message descriptions
  • Removed default configs

fixes #27870

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the examples Issue/PR related to examples label Aug 20, 2021
@HaNdTriX HaNdTriX mentioned this pull request Aug 20, 2021
Closed
@HaNdTriX
Update with-react-intl example
518a032 
## Changelog

- Updated formatjs to latest version
- Remove  deprecated babel-react-intl-plugin in favor of babel-formatjs-plugin
- Remove server in favour of Internationalized Routing
- Added linter with formatjs rules
- Refactored JSX
- Added missing types
- Auto run formtjs script via before hooks
- Adjusted readme docs
- Added message descriptions
- Removed default configs
ijjk
ijjk approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 6124e7d into vercel:canary Sep 20, 2021
@HaNdTriX HaNdTriX deleted the examples/with-react-intl branch September 20, 2021 07:44
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"with-react-intl" Not possible to check in Chrome
2 participants
@HaNdTriX @ijjk