Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade swc/core to 1.2.80 #28347

Merged
merged 2 commits into from Aug 20, 2021
Merged

feat: upgrade swc/core to 1.2.80 #28347

merged 2 commits into from Aug 20, 2021

Conversation

awareness481
Copy link
Contributor

Closes #28230

@ijjk

This comment has been minimized.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the lockfile too.

yarn add --dev -W @swc/core@latest

Then commit the yarn.lock file

@awareness481
Copy link
Contributor Author

@styfle Oh my bad, I wasn't thinking.

Glad you caught that. yarn.lock is added now

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Aug 20, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary awareness481/next.js-1 canary Change
buildDuration 16.8s 16.9s ⚠️ +131ms
buildDurationCached 4.1s 4.2s ⚠️ +113ms
nodeModulesSize 61.4 MB 61.4 MB -2 B
Page Load Tests Overall increase ✓
vercel/next.js canary awareness481/next.js-1 canary Change
/ failed reqs 0 0
/ total time (seconds) 3.151 3.079 -0.07
/ avg req/sec 793.52 811.86 +18.34
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.977 1.944 -0.03
/error-in-render avg req/sec 1264.55 1286.17 +21.62
Client Bundles (main, webpack, commons)
vercel/next.js canary awareness481/next.js-1 canary Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.2 kB 23.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary awareness481/next.js-1 canary Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary awareness481/next.js-1 canary Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary awareness481/next.js-1 canary Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary awareness481/next.js-1 canary Change
index.html gzip 541 B 541 B
link.html gzip 553 B 553 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary awareness481/next.js-1 canary Change
buildDuration 14.3s 14.7s ⚠️ +408ms
buildDurationCached 5.8s 6s ⚠️ +124ms
nodeModulesSize 61.4 MB 61.4 MB -2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary awareness481/next.js-1 canary Change
/ failed reqs 0 0
/ total time (seconds) 3.324 3.266 -0.06
/ avg req/sec 752.12 765.53 +13.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.904 2.005 ⚠️ +0.1
/error-in-render avg req/sec 1313.03 1246.87 ⚠️ -66.16
Client Bundles (main, webpack, commons)
vercel/next.js canary awareness481/next.js-1 canary Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary awareness481/next.js-1 canary Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary awareness481/next.js-1 canary Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.98 kB 2.98 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary awareness481/next.js-1 canary Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary awareness481/next.js-1 canary Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 577 B 577 B
Overall change 1.76 kB 1.76 kB
Commit: 9e909fb

@ijjk ijjk merged commit 8737ac0 into vercel:canary Aug 20, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Contributing] Running yarn on the Next.js repo fails with an error
3 participants