Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unit tests to one folder and migrate them to TypeScript #28427

Merged
merged 7 commits into from Aug 24, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 23, 2021

This migrates all of our unit tests that were previously suffixed with .unit.test.js to a single test/unit folder removing the redundant suffix. A root tsconfig.json has also been added to enable type checking the newly converted tests to help prevent test errors from incorrect usage.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Aug 23, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review August 23, 2021 23:53
@ijjk
Copy link
Member Author

ijjk commented Aug 24, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
buildDuration 12.8s 12.7s -82ms
buildDurationCached 3s 2.9s -57ms
nodeModulesSize 61.7 MB 61.7 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
/ failed reqs 0 0
/ total time (seconds) 2.298 2.282 -0.02
/ avg req/sec 1087.99 1095.7 +7.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.259 1.233 -0.03
/error-in-render avg req/sec 1986.38 2027.4 +41.02
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
buildDuration 10.5s 10.9s ⚠️ +486ms
buildDurationCached 4.5s 4.6s ⚠️ +78ms
nodeModulesSize 61.7 MB 61.7 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
/ failed reqs 0 0
/ total time (seconds) 2.322 2.323 0
/ avg req/sec 1076.69 1076.23 ⚠️ -0.46
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.234 1.263 ⚠️ +0.03
/error-in-render avg req/sec 2026.55 1980.08 ⚠️ -46.47
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3 kB 3 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
_buildManifest.js gzip 501 B 501 B
Overall change 501 B 501 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js tests/move-unit-tests Change
index.html gzip 586 B 586 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: cc1a3bc

@ijjk

This comment has been minimized.

@ijjk ijjk merged commit 005b13f into vercel:canary Aug 24, 2021
@ijjk ijjk deleted the tests/move-unit-tests branch August 24, 2021 12:52
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants